commit | 499e3a2786037114d0ecde6a7dfecdcfbbaf3e8a | [log] [tgz] |
---|---|---|
author | Lalit Maganti <lalitm@google.com> | Thu Jan 09 13:56:51 2020 +0000 |
committer | Lalit Maganti <lalitm@google.com> | Thu Jan 09 13:56:51 2020 +0000 |
tree | 68d3ab81c3a7b6078129618e4b8a8af61b60313e | |
parent | 7f86589d1522ce8bfc59f6b569ca52496a53eb79 [diff] |
perfetto: fix several problems with CTS The problems: 1) Previously, we were creating a new thread with a producer on every resume of the activity. As resumes do not necessarily correspond to process death, we were ending up with n producers (where n is the number of tests which ran before the activity test). 2) We were not cleaning up producers correctly and were instead relying on process death. However, it's very possible that an activity gets recreated without process death (as we have foreground services). 3) When we refactored CTS deps to not have to repeat tests, we accidentally stopped running integration tests in CTS. Solutions: 1) Setup "proper" producer lifecycle handling (this is still pretty hacky but significantly better than it was before) by tying the lifecycle of the producer to the lifecycle of the containing Java Android owner. 2) Reintroduce the integration tests source set into the CTS tests. Bug: 146984689 Change-Id: I2b0bed6f9f451057e93cb2d380962f6af0117efc
Perfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.
See www.perfetto.dev for docs.
See /docs/contributing.md for instructions.
The source-of-truth repo is Android's Gerrit. The GitHub repo is a read-only mirror.
You can reach us on our Discord channel. If you prefer using IRC we have an experimental Discord <> IRC bridge synced with #perfetto-dev
on Freenode.