commit 4f5db1b5de26ec3865302099e5a06ce15974b4d2
author Harvey Yang <chenghaoyang@chromium.org> Thu Oct 28 15:02:03 2021 +0800
committer Harvey Yang <chenghaoyang@chromium.org> Thu Oct 28 15:06:14 2021 +0800
tree a79feeebd3f2c091c3eea982d93f437b508fc825
parent 7372dc5cd76b62a429fa84d8c865e66ac07a8158

bazel: allow overriding perfetto_cc_ipc_library and perfetto_cc_protocpp_library

Amending CL:1867790, the two macros need to support overriding more
rules in internal google builds as well, for other targets such as
traced and traced_probes, to propagate non_prod rules internally.

R=lalitm@google.com, primiano@google.com
CC=chinglinyu@google.com, eseckler@google.com, skyostil@google.com

Change-Id: Icfbc746048d9addb4080601104eccfac290bb1b4

bazel/rules.bzl

diff --git a/bazel/rules.bzl b/bazel/rules.bzl
index d191297..49d4aaf 100644
--- a/bazel/rules.bzl
+++ b/bazel/rules.bzl
@@ -160,17 +160,19 @@
         fail("Too many proto deps for target %s" % name)
 
     # Generates .ipc.{cc,h}.
-    proto_gen(
-        name = name + "_src",
-        deps = _proto_deps,
-        suffix = "ipc",
-        plugin = PERFETTO_CONFIG.root + ":ipc_plugin",
-        wrapper_namespace = "gen",
-        protoc = PERFETTO_CONFIG.deps.protoc[0],
-        root = PERFETTO_CONFIG.root,
-    )
+    args = {
+        'name': name + "_src",
+        'deps': _proto_deps,
+        'suffix': "ipc",
+        'plugin': PERFETTO_CONFIG.root + ":ipc_plugin",
+        'wrapper_namespace': "gen",
+        'protoc': PERFETTO_CONFIG.deps.protoc[0],
+        'root': PERFETTO_CONFIG.root,
+    }
+    if not _rule_override("proto_gen", **args):
+        proto_gen(**args)
 
-    native.filegroup(
+    perfetto_filegroup(
         name = name + "_h",
         srcs = [":" + name + "_src"],
         output_group = "h",
@@ -209,17 +211,19 @@
     if len(_proto_deps) != 1:
         fail("Too many proto deps for target %s" % name)
 
-    proto_gen(
-        name = name + "_gen",
-        deps = _proto_deps,
-        suffix = "gen",
-        plugin = PERFETTO_CONFIG.root + ":cppgen_plugin",
-        wrapper_namespace = "gen",
-        protoc = PERFETTO_CONFIG.deps.protoc[0],
-        root = PERFETTO_CONFIG.root,
-    )
+    args = {
+        'name': name + "_gen",
+        'deps': _proto_deps,
+        'suffix': "gen",
+        'plugin': PERFETTO_CONFIG.root + ":cppgen_plugin",
+        'wrapper_namespace': "gen",
+        'protoc': PERFETTO_CONFIG.deps.protoc[0],
+        'root': PERFETTO_CONFIG.root,
+    }
+    if not _rule_override("proto_gen", **args):
+        proto_gen(**args)
 
-    native.filegroup(
+    perfetto_filegroup(
         name = name + "_gen_h",
         srcs = [":" + name + "_gen"],
         output_group = "h",