Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / external / perfetto / 514135fb1a37ba15cf7daad4918e17cfc1724de4
commit514135fb1a37ba15cf7daad4918e17cfc1724de4[log] [tgz]
authorPrimiano Tucci <primiano@google.com>Thu Dec 09 10:48:03 2021 +0000
committerPrimiano Tucci <primiano@google.com>Thu Dec 09 10:48:03 2021 +0000
tree310a6ec3da8582b49d5db205d20e99cb919a5977
parent4c498af99c43ed99d2f50791c1ddcbae37ff1fff [diff]
Speculative fix of Windows build (take 2)

Remove PERFETTO_EXPORT from ScopedResource as the class
is fully defined inline and has no symbols.
This seems to create problems when instantiating it in an
anonymous namespace on Windows:

From https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8828353581767219057/+/u/compile__with_patch_/stdout
../../third_party/perfetto/include\perfetto/ext/base/scoped_file.h(54,23): error: 'perfetto::base::ScopedResource<void *, &perfetto::base::ListFilesRecursive(const std::string &, std::vector<std::string> &)::(anonymous class)::__invoke, nullptr, false, perfetto::base::PlatformHandleChecker>' must have external linkage when declared 'dllexport'
class PERFETTO_EXPORT ScopedResource {
                      ^

Change-Id: I264973225637b60de52fe0d963c1dc1bc7741b75
1 file changed
tree: 310a6ec3da8582b49d5db205d20e99cb919a5977
  1. .github/
  2. bazel/
  3. build_overrides/
  4. buildtools/
  5. debian/
  6. docs/
  7. examples/
  8. gn/
  9. include/
  10. infra/
  11. protos/
  12. src/
  13. test/
  14. tools/
  15. ui/
  16. .clang-format
  17. .clang-tidy
  18. .gitattributes
  19. .gitignore
  20. .gn
  21. .style.yapf
  22. Android.bp
  23. Android.bp.extras
  24. BUILD
  25. BUILD.extras
  26. BUILD.gn
  27. CHANGELOG
  28. codereview.settings
  29. DIR_METADATA
  30. heapprofd.rc
  31. LICENSE
  32. meson.build
  33. METADATA
  34. MODULE_LICENSE_APACHE2
  35. OWNERS
  36. perfetto.rc
  37. PerfettoIntegrationTests.xml
  38. PRESUBMIT.py
  39. README.chromium
  40. README.md
  41. TEST_MAPPING
  42. traced_perf.rc
  43. WORKSPACE
README.md

Perfetto - System profiling, app tracing and trace analysis

Perfetto is a production-grade open-source stack for performance instrumentation and trace analysis. It offers services and libraries and for recording system-level and app-level traces, native + java heap profiling, a library for analyzing traces using SQL and a web-based UI to visualize and explore multi-GB traces.

See https://perfetto.dev/docs or the /docs/ directory for documentation.