| commit | 61412fc01b3cee03858818239a88cdb04fc4c728 | [log] [tgz] |
|---|---|---|
| author | Sami Kyostila <skyostil@chromium.org> | Mon Sep 14 13:37:51 2020 +0100 |
| committer | Sami Kyostila <skyostil@chromium.org> | Mon Sep 14 13:37:51 2020 +0100 |
| tree | 9b794610340ba6cccadb967e79ea25dc6f01e4b8 | |
| parent | 617d3f67c3d963d2bd8b1f70cc60b660123e8153 [diff] |
cppgen: Don't require full submessage definitions in gen headers Previously it wasn't possible to include a gen-header for a message containing repeated fields of submessages without also including the full definitions of those submessages. This is because vector accessors (e.g., field_size()) need to have the full definition of the repeated type, even if that accessor isn't called. InternedData is an example of a message affected by this problem. Trying to include interned_data.gen.h in Chrome meant having to include the definitions of all submessages first (e.g., source_location.gen.h). If someone added a new field upstream, that breaks the build in Chrome. This patch fixes the problem by moving the definitions of repeated field accessors from gen.h to gen.cc. Bug: 156727531 Change-Id: Ic1f43b6a75a44f6ca98fa58b8b7b13a4f74fd5d5
Perfetto is a production-grade open-source stack for performance instrumentation and trace analysis. It offers services and libraries and for recording system-level and app-level traces, native + java heap profiling, a library for analyzing traces using SQL and a web-based UI to visualize and explore multi-GB traces.
See https://perfetto.dev/docs or the /docs/ directory for documentation.