| commit | 58da68b8fe4ab7d41d73350753f0642b6f0e1213 | [log] [tgz] |
|---|---|---|
| author | Lalit Maganti <lalitm@google.com> | Thu Aug 29 14:19:07 2019 +0100 |
| committer | Lalit Maganti <lalitm@google.com> | Thu Aug 29 14:19:07 2019 +0100 |
| tree | 5b03212c6421f8f98bcdae2e81b4f4bdd7e5ebae | |
| parent | 6dc3546ccbe4df6fc8bfc31211271b39c535d73d [diff] |
trace_processor: remove SqliteTable::ColumnType Originally, SqliteTable::ColumnType was concieved to have strong typing of columns in SQLite. Unfortunately, over time, we've come to the realisation that given that SQLite doesn't care about this info and columns can be null, it is hard to enforce true strong typing. Instead the best we can do is group into type "groups" (int, double, string and bytes) which is well supported by SQLite. Until now, we have tried to maintain the notion of strong types through the type passed to the schema even though we don't (and can't) really use it in any useful way. This CL removes ColumnType and replaces it with SqlValue::Type which contains the column groups mentioned above. This is necessary to allow for a cleaner transition to macro based tables. Change-Id: I0b6516b0296588444b5a5b3da9d844e8f5917872 Bug: 135177627
Perfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.
See www.perfetto.dev for docs.