Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / external / perfetto / 5ac48daf06756a3bb1d3e1f9bd730462d4120617
commit5ac48daf06756a3bb1d3e1f9bd730462d4120617[log] [tgz]
authorLalit Maganti <lalitm@google.com>Mon Feb 05 16:17:08 2018 +0000
committerLalit Maganti <lalitm@google.com>Mon Feb 05 16:17:08 2018 +0000
treeeab7ac84a110cd3cc95869ecb0f3f9ccd1e92161
parent6a2a99286db4a416a0ad17878b591539c34c9afc [diff]
perfetto: fix dcheck in patch list generation

When a nested message inside a TracePacket is spread over three chunks,
it is possible to get to the state where the size field is not in the
current chunk but in the patch list itself.

Fix the DCHECK to allow for this situation.

Bug: 72685438
Change-Id: I398ba81896a20ebfe56cc3884f909607784344f8
1 file changed
tree: eab7ac84a110cd3cc95869ecb0f3f9ccd1e92161
  1. build_overrides/
  2. buildtools/
  3. cts/
  4. debian/
  5. docs/
  6. gn/
  7. include/
  8. infra/
  9. protos/
  10. src/
  11. test/
  12. tools/
  13. .clang-format
  14. .gitignore
  15. .gn
  16. .travis.yml
  17. Android.bp
  18. Android.bp.extras
  19. BUILD.gn
  20. codereview.settings
  21. MODULE_LICENSE_APACHE2
  22. NOTICE
  23. OWNERS
  24. perfetto.rc
  25. PRESUBMIT.py
  26. README.chromium
  27. README.md
README.md

Perfetto - Performance instrumentation and logging for POSIX platforms

This project is meant to be built both as part of the Android tree and from a standalone checkout

For internal docs see this page

Supported platforms

Android is the platform targeted in the first milestones. Right now Linux desktop and OSX are maintained best-effort.

Contributing

This project uses Android AOSP Gerrit for code reviews and uses the Google C++ style. Currently targets -std=c++11.

You can use both git cl upload from Chromium depot tools or Android repo to upload patches.

git cl is quite convenient as it supports code auto-formatting via git cl format.

See https://source.android.com/source/contributing for more details about external contributions and CLA signing.

Build instructions

See docs/build_instructions.md

Running Perfetto

See docs/running_perfetto.md

Continuous integration

Continuous build and test coverage is available at perfetto-ci.appspot.com. Trybots: CLs uploaded to gerrit are automatically submitted to TravisCI within one minute and made available on the CI page above. The relevant code lives in the infra/ directory.

Run tests

On the host (Linux / OSX)

$ tools/ninja -C out/default (tracing_unittests | tracing_benchmarks)
$ out/default/tracing_unittests --gtest_help

On Android

Either connect a device in ADB mode or use the bundled emulator.

To start the emulator:
$ tools/run_android_emulator (arm | arm64) &

To run the tests (either on the emulator or physical device):
$ tools/run_android_test out/default tracing_unittests