commit | 5d40eca0de4d3e907944dbf9251552219d125f16 | [log] [tgz] |
---|---|---|
author | Primiano Tucci <primiano@google.com> | Mon Nov 22 20:18:01 2021 +0000 |
committer | Primiano Tucci <primiano@google.com> | Mon Nov 22 20:18:01 2021 +0000 |
tree | dac02f8eba18773e1d0f69e232397079e8be7ef8 | |
parent | 03cb3fd2f9c1b7475bf3838ecdf014b786b791f3 [diff] |
[base] FlatHashMap: don't invalidate pointer if key exists Before this CL the insertion code caused both: - Insert(already_existing_key, ...) - operator[](already_existing_key) To rehash, and hence invalidate pointers, even in the case of the key already existing. This is because the load-factor check was performed in the Insert() prologue, before even checking if the key did exist already. This CL also gets rid of the |size_plus_tombstones_| and makes the load check just based on the |size_|. The extra layer of complexity didn't bring any meaningful benefit. Test: FlatHashMapTest.DontRehashIfKeyAlreadyExists Bug: crbug.com/1272018 Bug: 207393956 Change-Id: I9d7c6a7a86fd16656fd6c41a5778fb7705b2418e
Perfetto is a production-grade open-source stack for performance instrumentation and trace analysis. It offers services and libraries and for recording system-level and app-level traces, native + java heap profiling, a library for analyzing traces using SQL and a web-based UI to visualize and explore multi-GB traces.
See https://perfetto.dev/docs or the /docs/ directory for documentation.