commit | 7449dc8a7f22156ee7a2bc2157260480938850e1 | [log] [tgz] |
---|---|---|
author | Lalit Maganti <lalitm@google.com> | Mon Dec 30 15:52:35 2019 +0000 |
committer | Lalit Maganti <lalitm@google.com> | Mon Dec 30 15:52:35 2019 +0000 |
tree | 00495be2175f72cb557af08b8b2a7fb27e373b46 | |
parent | f04938adfc40c1ae4425fdc6a70f9b14961146f5 [diff] |
trace_processor: remove RowId type from trace_processor This CL removes the RowId type completely from trace processor. Initially the type was introduced to uniquely identify a row in trace processor and to use as a join key. However, with the advent of db tables, we no longer need this ability so we can get rid of the concept. As there is still a few dependencies on RowId, this CL also does the following: 1. Changes ArgsTracker to use TableId + row number to identify which row an arg belongs to. 2. Add the concept of a BoundInserter to ArgsTracker. A BoundInserter is a class which allows callers to add args to the args tracker without specifying the table and row - this is because when the BoundInserter is created, it is assigned to a Row. By doing this, we reduce the amount of complexity throughout trace processor significantly when dealing with args 3. Change SliceTracker to use BoundInserter. 4. Change all callsites throughout trace processor to use BoundInserter and ArgsTracker properly. Change-Id: I5034ebb6e47af1387dec7f4d8919f91e8dd43c97
Perfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.
See www.perfetto.dev for docs.
See /docs/contributing.md for instructions.
The source-of-truth repo is Android's Gerrit. The GitHub repo is a read-only mirror.
You can reach us on our Discord channel. If you prefer using IRC we have an experimental Discord <> IRC bridge synced with #perfetto-dev
on Freenode.