commit 8083765f2814e3f19a35b410e389fa1814a81c92
author Ryan <rsavitski@google.com> Tue May 25 13:45:59 2021 +0100
committer Ryan Savitski <rsavitski@google.com> Tue May 25 14:09:52 2021 +0000
tree 190ded9d0485586cfcd70b732b14c89463f43a38
parent edd5c13fe67bdc5a68a92e6cc3101a17214c4c5d

tracing_service: reject entire session if a DS has an out of bounds target_buffer

Currently, if the config has an incorrect target_buffer (e.g. 2 for a
config with only 1 buffer) for one of its data sources, the
SetupDataSource skips that particular data source, without notifying the
consumer.

This patch adds an earlier check (in EnableTracing), which rejects the
entire session if its config has such an erroneous data source. I
believe that this config error is both critical AND rare enough that
it's fine to reject the whole trace for, but I could be convinced that
the graceful degradation of running the valid configs is preferable.

Reason for the change: I've seen this error made with manually-edited
configs firsthand, and it wasn't obvious what was wrong since the
consumer isn't told of the error at the moment.

Change-Id: I1d08952701cf03b78dda75f8d18486bd2794b157