| commit | 29885798ac66d92369e98bc90a51ee2d2e497ec4 | [log] [tgz] |
|---|---|---|
| author | Ryan Savitski <rsavitski@google.com> | Thu Mar 14 12:10:13 2019 +0000 |
| committer | Ryan Savitski <rsavitski@google.com> | Thu Mar 14 12:10:13 2019 +0000 |
| tree | 61f762a05fd4f94303a2307d72b04c9f347bf1c3 | |
| parent | f702532c71518410b9e9c738bd88516b7e6863c4 [diff] |
introduce ThreadTaskRunner and use it in heapprofd's UnwindingWorker As discussed last week, proposing a wrapper object that owns a UnixTaskRunner & its task thread. For the review, please focus on the following: * that the writeup of the thread-checking considerations in unix_task_runner.h is accurate * that the thread_task_runner implementation itself is sane * that its use in heapprofd is reasonable I have no strong opinions on the following, and simply chose one option for the initial review: * Naming of the new utility - ThreadUnixTaskRunner would more accurately reflect that this isn't cross-platform? * Whether it belongs in base::, or should be in profiling::memory:: for now. We can slot this into consumer_api.cc (which does a very similar handshake) in a followup cl, so I thought base:: might be a reasonable place. Note: with this change, heapprofd works in debug builds e2e afaict. Change-Id: Ia12c89c6963bf0a659bca7994f4fe87aa3bfde58
Perfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.
See www.perfetto.dev for docs.