trace_processor: Remove PERFETTO_TP_ANDROID_PROBES build flag
The android_probes module is moved to storage_full.
Bug: 141459049
Change-Id: I5ad9e5a589f31959c282042887e9f720eb43bf8c
diff --git a/Android.bp b/Android.bp
index f2abac3..827c726 100644
--- a/Android.bp
+++ b/Android.bp
@@ -5740,6 +5740,8 @@
filegroup {
name: "perfetto_src_trace_processor_storage_full",
srcs: [
+ "src/trace_processor/importers/proto/android_probes_module.cc",
+ "src/trace_processor/importers/proto/android_probes_parser.cc",
"src/trace_processor/importers/proto/graphics_event_module.cc",
"src/trace_processor/importers/proto/graphics_event_parser.cc",
"src/trace_processor/importers/proto/system_probes_module.cc",
@@ -5772,8 +5774,6 @@
"src/trace_processor/importers/fuchsia/fuchsia_trace_parser.cc",
"src/trace_processor/importers/fuchsia/fuchsia_trace_tokenizer.cc",
"src/trace_processor/importers/fuchsia/fuchsia_trace_utils.cc",
- "src/trace_processor/importers/proto/android_probes_module.cc",
- "src/trace_processor/importers/proto/android_probes_parser.cc",
"src/trace_processor/importers/proto/args_table_utils.cc",
"src/trace_processor/importers/proto/heap_graph_module.cc",
"src/trace_processor/importers/proto/heap_graph_tracker.cc",
diff --git a/BUILD b/BUILD
index 08de559..71698f7 100644
--- a/BUILD
+++ b/BUILD
@@ -775,6 +775,10 @@
filegroup(
name = "src_trace_processor_storage_full",
srcs = [
+ "src/trace_processor/importers/proto/android_probes_module.cc",
+ "src/trace_processor/importers/proto/android_probes_module.h",
+ "src/trace_processor/importers/proto/android_probes_parser.cc",
+ "src/trace_processor/importers/proto/android_probes_parser.h",
"src/trace_processor/importers/proto/graphics_event_module.cc",
"src/trace_processor/importers/proto/graphics_event_module.h",
"src/trace_processor/importers/proto/graphics_event_parser.cc",
@@ -838,10 +842,6 @@
"src/trace_processor/importers/json/json_trace_tokenizer.h",
"src/trace_processor/importers/json/json_trace_utils.cc",
"src/trace_processor/importers/json/json_trace_utils.h",
- "src/trace_processor/importers/proto/android_probes_module.cc",
- "src/trace_processor/importers/proto/android_probes_module.h",
- "src/trace_processor/importers/proto/android_probes_parser.cc",
- "src/trace_processor/importers/proto/android_probes_parser.h",
"src/trace_processor/importers/proto/args_table_utils.cc",
"src/trace_processor/importers/proto/args_table_utils.h",
"src/trace_processor/importers/proto/chrome_compositor_scheduler_state.descriptor.h",
diff --git a/gn/BUILD.gn b/gn/BUILD.gn
index 0042b64..1544497 100644
--- a/gn/BUILD.gn
+++ b/gn/BUILD.gn
@@ -84,7 +84,6 @@
"PERFETTO_TP_METRICS=$enable_perfetto_trace_processor_metrics",
"PERFETTO_TP_FTRACE=$enable_perfetto_trace_processor_ftrace",
"PERFETTO_TP_HTTPD=$perfetto_tp_httpd",
- "PERFETTO_TP_ANDROID_PROBES=$enable_perfetto_trace_processor_android_probes",
"PERFETTO_TP_HEAP_GRAPHS=$enable_perfetto_trace_processor_heap_graphs",
"PERFETTO_TP_JSON=$enable_perfetto_trace_processor_json",
"PERFETTO_TP_JSON_IMPORT=$enable_perfetto_trace_processor_json_import",
diff --git a/gn/perfetto.gni b/gn/perfetto.gni
index d488cab..3522b94 100644
--- a/gn/perfetto.gni
+++ b/gn/perfetto.gni
@@ -219,10 +219,6 @@
enable_perfetto_trace_processor_ftrace =
enable_perfetto_trace_processor && !(build_with_chromium && is_android)
- # Enables parsing support for android system probes in trace processor.
- enable_perfetto_trace_processor_android_probes =
- enable_perfetto_trace_processor && !(build_with_chromium && is_android)
-
# Enables parsing support for heap graphs in trace processor.
enable_perfetto_trace_processor_heap_graphs =
enable_perfetto_trace_processor && !(build_with_chromium && is_android)
@@ -252,8 +248,7 @@
# Enables syscall support in trace processor. Required for ftrace, system
# probes, and android probes support.
enable_perfetto_trace_processor_syscalls =
- enable_perfetto_trace_processor_ftrace ||
- enable_perfetto_trace_processor_android_probes
+ enable_perfetto_trace_processor_ftrace
# Enables metrics support in the trace processor, which require SQL support.
enable_perfetto_trace_processor_metrics =
@@ -313,5 +308,4 @@
# Syscall support is required for ftrace, system probes, and android probes.
assert(enable_perfetto_trace_processor_syscalls ||
- (!enable_perfetto_trace_processor_ftrace &&
- !enable_perfetto_trace_processor_android_probes))
+ !enable_perfetto_trace_processor_ftrace)
diff --git a/include/perfetto/base/build_configs/android_tree/perfetto_build_flags.h b/include/perfetto/base/build_configs/android_tree/perfetto_build_flags.h
index 2e23b4b..3cef49f 100644
--- a/include/perfetto/base/build_configs/android_tree/perfetto_build_flags.h
+++ b/include/perfetto/base/build_configs/android_tree/perfetto_build_flags.h
@@ -38,7 +38,6 @@
#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_METRICS() (1)
#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_FTRACE() (1)
#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_HTTPD() (0)
-#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_ANDROID_PROBES() (1)
#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_HEAP_GRAPHS() (1)
#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_JSON() (0)
#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_JSON_IMPORT() (0)
diff --git a/include/perfetto/base/build_configs/bazel/perfetto_build_flags.h b/include/perfetto/base/build_configs/bazel/perfetto_build_flags.h
index a43574c..86b8cc3 100644
--- a/include/perfetto/base/build_configs/bazel/perfetto_build_flags.h
+++ b/include/perfetto/base/build_configs/bazel/perfetto_build_flags.h
@@ -38,7 +38,6 @@
#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_METRICS() (1)
#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_FTRACE() (1)
#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_HTTPD() (PERFETTO_BUILDFLAG_DEFINE_PERFETTO_OS_ANDROID() || PERFETTO_BUILDFLAG_DEFINE_PERFETTO_OS_LINUX() || PERFETTO_BUILDFLAG_DEFINE_PERFETTO_OS_MACOSX())
-#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_ANDROID_PROBES() (1)
#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_HEAP_GRAPHS() (1)
#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_JSON() (1)
#define PERFETTO_BUILDFLAG_DEFINE_PERFETTO_TP_JSON_IMPORT() (1)
diff --git a/src/trace_processor/BUILD.gn b/src/trace_processor/BUILD.gn
index ee22ca1..9604696 100644
--- a/src/trace_processor/BUILD.gn
+++ b/src/trace_processor/BUILD.gn
@@ -101,8 +101,6 @@
"importers/ftrace/ftrace_tokenizer.h",
"importers/ftrace/sched_event_tracker.h",
"importers/fuchsia/fuchsia_provider_view.h",
- "importers/proto/android_probes_module.h",
- "importers/proto/android_probes_parser.h",
"importers/proto/args_table_utils.cc",
"importers/proto/args_table_utils.h",
"importers/proto/chrome_compositor_scheduler_state.descriptor.h",
@@ -203,13 +201,6 @@
enable_perfetto_trace_processor_fuchsia) {
sources += [ "ftrace_utils.cc" ]
}
- if (enable_perfetto_trace_processor_android_probes) {
- sources += [
- "importers/proto/android_probes_module.cc",
- "importers/proto/android_probes_parser.cc",
- ]
- deps += [ "../../include/perfetto/ext/traced:sys_stats_counters" ]
- }
if (enable_perfetto_trace_processor_heap_graphs) {
sources += [
"importers/proto/heap_graph_module.cc",
@@ -241,6 +232,10 @@
source_set("storage_full") {
sources = [
+ "importers/proto/android_probes_module.cc",
+ "importers/proto/android_probes_module.h",
+ "importers/proto/android_probes_parser.cc",
+ "importers/proto/android_probes_parser.h",
"importers/proto/graphics_event_module.cc",
"importers/proto/graphics_event_module.h",
"importers/proto/graphics_event_parser.cc",
diff --git a/src/trace_processor/importers/proto/proto_trace_parser_unittest.cc b/src/trace_processor/importers/proto/proto_trace_parser_unittest.cc
index aab449a..8df34cd 100644
--- a/src/trace_processor/importers/proto/proto_trace_parser_unittest.cc
+++ b/src/trace_processor/importers/proto/proto_trace_parser_unittest.cc
@@ -24,11 +24,9 @@
#include "src/trace_processor/event_tracker.h"
#include "src/trace_processor/importers/ftrace/ftrace_module.h"
#include "src/trace_processor/importers/ftrace/sched_event_tracker.h"
-#include "src/trace_processor/importers/proto/android_probes_module.h"
#include "src/trace_processor/importers/proto/heap_graph_module.h"
#include "src/trace_processor/importers/proto/proto_importer_module.h"
#include "src/trace_processor/importers/proto/proto_trace_parser.h"
-#include "src/trace_processor/importers/proto/system_probes_module.h"
#include "src/trace_processor/importers/proto/track_event_module.h"
#include "src/trace_processor/importers/systrace/systrace_parser.h"
#include "src/trace_processor/metadata.h"
@@ -258,9 +256,6 @@
#if PERFETTO_BUILDFLAG(PERFETTO_TP_HEAP_GRAPHS)
context_.modules.emplace_back(new HeapGraphModule(&context_));
#endif // PERFETTO_BUILDFLAG(PERFETTO_TP_HEAP_GRAPHS)
-#if PERFETTO_BUILDFLAG(PERFETTO_TP_ANDROID_PROBES)
- context_.modules.emplace_back(new AndroidProbesModule(&context_));
-#endif // PERFETTO_BUILDFLAG(PERFETTO_TP_ANDROID_PROBES)
context_.modules.emplace_back(new TrackEventModule(&context_));
RegisterAdditionalModules(&context_);
@@ -2451,7 +2446,6 @@
Variadic::String(3))}));
}
-#if PERFETTO_BUILDFLAG(PERFETTO_TP_ANDROID_PROBES)
TEST_F(ProtoTraceParserTest, AndroidPackagesList) {
auto* packet = trace_.add_packet();
auto* pkg_list = packet->set_packages_list();
@@ -2532,7 +2526,6 @@
false);
EXPECT_EQ(find_arg(second_set_id, "version_code").int_value, 43);
}
-#endif // PERFETTO_BUILDFLAG(PERFETTO_TP_ANDROID_PROBES)
TEST_F(ProtoTraceParserTest, ParseCPUProfileSamplesIntoTable) {
{
diff --git a/src/trace_processor/register_additional_modules.cc b/src/trace_processor/register_additional_modules.cc
index 55a365b..1b16fd9 100644
--- a/src/trace_processor/register_additional_modules.cc
+++ b/src/trace_processor/register_additional_modules.cc
@@ -15,6 +15,7 @@
*/
#include "src/trace_processor/register_additional_modules.h"
+#include "src/trace_processor/importers/proto/android_probes_module.h"
#include "src/trace_processor/importers/proto/graphics_event_module.h"
#include "src/trace_processor/importers/proto/system_probes_module.h"
@@ -22,6 +23,7 @@
namespace trace_processor {
void RegisterAdditionalModules(TraceProcessorContext* context) {
+ context->modules.emplace_back(new AndroidProbesModule(context));
context->modules.emplace_back(new GraphicsEventModule(context));
context->modules.emplace_back(new SystemProbesModule(context));
}
diff --git a/src/trace_processor/trace_processor_context.cc b/src/trace_processor/trace_processor_context.cc
index b5667f4..5dd858c 100644
--- a/src/trace_processor/trace_processor_context.cc
+++ b/src/trace_processor/trace_processor_context.cc
@@ -25,7 +25,6 @@
#include "src/trace_processor/importers/ftrace/ftrace_module.h"
#include "src/trace_processor/importers/ftrace/sched_event_tracker.h"
#include "src/trace_processor/importers/json/json_trace_parser.h"
-#include "src/trace_processor/importers/proto/android_probes_module.h"
#include "src/trace_processor/importers/proto/heap_graph_module.h"
#include "src/trace_processor/importers/proto/heap_graph_tracker.h"
#include "src/trace_processor/importers/proto/proto_trace_parser.h"
diff --git a/src/trace_processor/trace_processor_storage_impl.cc b/src/trace_processor/trace_processor_storage_impl.cc
index c7e3ad2..267a0f1 100644
--- a/src/trace_processor/trace_processor_storage_impl.cc
+++ b/src/trace_processor/trace_processor_storage_impl.cc
@@ -25,7 +25,6 @@
#include "src/trace_processor/heap_profile_tracker.h"
#include "src/trace_processor/importers/ftrace/ftrace_module.h"
#include "src/trace_processor/importers/ftrace/sched_event_tracker.h"
-#include "src/trace_processor/importers/proto/android_probes_module.h"
#include "src/trace_processor/importers/proto/heap_graph_module.h"
#include "src/trace_processor/importers/proto/heap_graph_tracker.h"
#include "src/trace_processor/importers/proto/proto_importer_module.h"
@@ -72,9 +71,6 @@
#if PERFETTO_BUILDFLAG(PERFETTO_TP_HEAP_GRAPHS)
context_.modules.emplace_back(new HeapGraphModule(&context_));
#endif // PERFETTO_BUILDFLAG(PERFETTO_TP_HEAP_GRAPHS)
-#if PERFETTO_BUILDFLAG(PERFETTO_TP_ANDROID_PROBES)
- context_.modules.emplace_back(new AndroidProbesModule(&context_));
-#endif // PERFETTO_BUILDFLAG(PERFETTO_TP_ANDROID_PROBES)
context_.modules.emplace_back(new TrackEventModule(&context_));
}