| commit | b3e08d0aaeeba870d7af6a8eba7dbaec8bbef8d0 | [log] [tgz] |
|---|---|---|
| author | Primiano Tucci <primiano@google.com> | Tue Nov 19 11:10:11 2019 +0000 |
| committer | Primiano Tucci <primiano@google.com> | Tue Nov 19 11:10:11 2019 +0000 |
| tree | 49c189de0df4f1011f895c38078e2dddd66845e0 | |
| parent | 6a7fa5f58be1ab3128b8c0f7cf9cd35c7ab88125 [diff] |
Use protozero in IPC framing protocol
This CL switches the root layer of the IPC to protozero.
Note that this CL doesn't fully remove the libprotobuf
dep from the IPC layer. The auto-generated .ipc.{cc,h}
classes, in fact, still refer to the .pb.h headers for
now (the next CL will sort that out).
This CL takes care only of the raw IPC machinery that
deals with framing (BufferedFrameDeserializer).
The major change introduced is making varint decoding
resilient against ints larger than 64 bits. The IPC
layer needs to defend against too-large frames.
Also failing varint decoding on numbers > 2**64
seems generally a nice property.
I manually inspected all other uses of ParseVarInt
and adapted the only other affected one (ProtoDecoder)
to this new behavior.
Bug: 132880619
Change-Id: I2c8b64ee7cf175a07f70845db04f0639bf3291afPerfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.
See www.perfetto.dev for docs.
You can reach us on our Discord channel. If you prefer using IRC we have an experimental Discord <> IRC bridge synced with #perfetto-dev on Freenode.