| commit | bb7e7c16e0a9a69c0940095249474c23214049ab | [log] [tgz] |
|---|---|---|
| author | Eric Seckler <eseckler@google.com> | Fri Dec 13 16:03:25 2019 +0000 |
| committer | Eric Seckler <eseckler@google.com> | Fri Dec 13 16:04:46 2019 +0000 |
| tree | 402b5204f751075acd2d829f3fdc5faf9499c277 | |
| parent | eefb5ed90bbead86ec8b4dc46ba35ddf7affc92d [diff] |
ui: Update target selection box correctly
The old logic to update the target selection box was flawed in two ways:
(1) After connecting a new Android device, we were first queuing an
action to update the state's available device list and then
immediately attempting to look up the new device in the old state's
device list (where it didn't exist yet). Fix by selecting the new
device directly without going through onTargetChange().
(2) A mithril bug prevented correct simultaneous update of the select's
options and selectedIndex. Work around this by updating the
selectedIndex manually in mithril's onupdate() lifecycle callback.
Also fix PostMessageHandler to ignore a common type of error that
happens often during local dev.
Change-Id: Iea043e209c247dee26543b211ccee544458ba793
Perfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.
See www.perfetto.dev for docs.
You can reach us on our Discord channel. If you prefer using IRC we have an experimental Discord <> IRC bridge synced with #perfetto-dev on Freenode.