| commit | eb5c71e3546fc629879d4da5d121d4c6aa6698c8 | [log] [tgz] |
|---|---|---|
| author | Hector Dearman <hjd@google.com> | Tue Jul 30 14:00:23 2019 +0100 |
| committer | Hector Dearman <hjd@google.com> | Tue Jul 30 14:00:23 2019 +0100 |
| tree | 696c0818c500cfdda9f79dd339c038c8962d1ba2 | |
| parent | d7462ebd111e199fe5ce1ea066050a60428dca75 [diff] |
traced: Send empty OnTraceData response if tracing not started Currently if a consumer attempts to ReadBuffers and tracing has not started the service never returns a response. This commonly occurs when the consumer fails to start tracing: the service sends OnTracingDisabled the consumer can't distinguish between this failure and a legitimate OnTracingDisabled and so calls ReadBuffers and waits forever for OnTracePacket. This: - Changes the service to send an empty response to OnTraceData allowing finalization in the client to proceed as normal - Updates perfetto_cmd to be more robust to these kinds of problems by adding a duration guardrail for background traces - Updates a log message to make sense for indefinite traces - Bumps the amount of leeway in the guardrail from 10s to 60s: finalizing the trace can take some time especially if compression is enabled Bug: 137831924 Change-Id: Ie5c48cbd9fd93834d27cee7e0adc1a763d8ac1f0
Perfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.
See www.perfetto.dev for docs.