| commit | fbb73b8b234520b75fe29ec9c692f635cbe35ff1 | [log] [tgz] |
|---|---|---|
| author | Primiano Tucci <primiano@google.com> | Fri Mar 24 13:21:33 2023 +0000 |
| committer | Primiano Tucci <primiano@google.com> | Mon Mar 27 09:56:09 2023 +0100 |
| tree | 228363dee9fd2143b689fbce8db12df2f35c4196 | |
| parent | 778d58485d13db0a8089fd0d4ef593d9f48deb97 [diff] |
traced: bail out if an invalid trigger mode is specified This is a fix to a subtle binary back-compat issue. When introducing a new trigger mode, the service will ignore it and trace indefinitely (Because duration_ms is checked to be 0). The issue is not as bad as initially though because perfetto_cmd mitigates this, by enforcing a hard timeout to 60s + trigger_timeout regardless of the type of the trigger (See comments in b/274931668). Bug: 274931668 Bug: 260112703 Test: perfetto_unittests --gtest_filter=TracingServiceImplTest.FailOnUnknownTriggerMode (cherry picked from commit 7f432673ea568e8ab9b7f4ccfe0107a4c5e01e81) Change-Id: I7993ec7a3604b8ede00b3c29cf29059685af4848 Merged-In: I7993ec7a3604b8ede00b3c29cf29059685af4848
Perfetto is a production-grade open-source stack for performance instrumentation and trace analysis. It offers services and libraries and for recording system-level and app-level traces, native + java heap profiling, a library for analyzing traces using SQL and a web-based UI to visualize and explore multi-GB traces.
See https://perfetto.dev/docs or the /docs/ directory for documentation.