Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 1 | # Copyright (C) 2017 The Android Open Source Project |
| 2 | # |
| 3 | # Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | # you may not use this file except in compliance with the License. |
| 5 | # You may obtain a copy of the License at |
| 6 | # |
| 7 | # http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | # |
| 9 | # Unless required by applicable law or agreed to in writing, software |
| 10 | # distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | # See the License for the specific language governing permissions and |
| 13 | # limitations under the License. |
| 14 | |
Florian Mayer | 640b7ae | 2018-05-09 15:28:32 +0100 | [diff] [blame] | 15 | import itertools |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 16 | import subprocess |
| 17 | |
Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 18 | def CheckChange(input, output): |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 19 | # There apparently is no way to wrap strings in blueprints, so ignore long |
| 20 | # lines in them. |
| 21 | long_line_sources = lambda x: input.FilterSourceFile( |
Primiano Tucci | 2c761ef | 2019-01-07 20:20:46 +0000 | [diff] [blame] | 22 | x, white_list=".*", |
Primiano Tucci | f7793ef | 2019-01-10 21:32:45 +0000 | [diff] [blame^] | 23 | black_list=['Android[.]bp', '.*[.]json$', '.*[.]sql$', '.*[.]out$', |
| 24 | 'test/trace_processor/index$']) |
Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 25 | results = [] |
| 26 | results += input.canned_checks.CheckDoNotSubmit(input, output) |
| 27 | results += input.canned_checks.CheckChangeHasNoTabs(input, output) |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 28 | results += input.canned_checks.CheckLongLines( |
| 29 | input, output, 80, source_file_filter=long_line_sources) |
Deepanjan Roy | a752b46 | 2018-07-04 01:24:31 +0100 | [diff] [blame] | 30 | results += input.canned_checks.CheckPatchFormatted( |
| 31 | input, output, check_js=True) |
Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 32 | results += input.canned_checks.CheckGNFormatted(input, output) |
Primiano Tucci | 40e9872 | 2018-02-16 11:50:17 +0000 | [diff] [blame] | 33 | results += CheckIncludeGuards(input, output) |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 34 | results += CheckAndroidBlueprint(input, output) |
Hector Dearman | 1e26914 | 2018-11-14 13:53:08 +0000 | [diff] [blame] | 35 | results += CheckBinaryDescriptors(input, output) |
Primiano Tucci | c501080 | 2018-01-19 17:13:21 +0000 | [diff] [blame] | 36 | results += CheckMergedTraceConfigProto(input, output) |
Florian Mayer | 640b7ae | 2018-05-09 15:28:32 +0100 | [diff] [blame] | 37 | results += CheckWhitelist(input, output) |
Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 38 | return results |
| 39 | |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 40 | |
Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 41 | def CheckChangeOnUpload(input_api, output_api): |
| 42 | return CheckChange(input_api, output_api) |
| 43 | |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 44 | |
Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 45 | def CheckChangeOnCommit(input_api, output_api): |
| 46 | return CheckChange(input_api, output_api) |
| 47 | |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 48 | |
| 49 | def CheckAndroidBlueprint(input_api, output_api): |
| 50 | # If no GN files were modified, bail out. |
| 51 | build_file_filter = lambda x: input_api.FilterSourceFile( |
| 52 | x, |
| 53 | white_list=('.*BUILD[.]gn$', '.*[.]gni$', 'tools/gen_android_bp')) |
| 54 | if not input_api.AffectedSourceFiles(build_file_filter): |
| 55 | return [] |
| 56 | |
| 57 | with open('Android.bp') as f: |
| 58 | current_blueprint = f.read() |
Primiano Tucci | 40e9872 | 2018-02-16 11:50:17 +0000 | [diff] [blame] | 59 | |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 60 | new_blueprint = subprocess.check_output( |
| 61 | ['tools/gen_android_bp', '--output', '/dev/stdout']) |
| 62 | |
| 63 | if current_blueprint != new_blueprint: |
| 64 | return [ |
| 65 | output_api.PresubmitError( |
| 66 | 'Android.bp is out of date. Please run tools/gen_android_bp ' |
| 67 | 'to update it.') |
| 68 | ] |
| 69 | return [] |
Primiano Tucci | c501080 | 2018-01-19 17:13:21 +0000 | [diff] [blame] | 70 | |
| 71 | |
Primiano Tucci | 40e9872 | 2018-02-16 11:50:17 +0000 | [diff] [blame] | 72 | def CheckIncludeGuards(input_api, output_api): |
| 73 | tool = 'tools/fix_include_guards' |
| 74 | file_filter = lambda x: input_api.FilterSourceFile( |
| 75 | x, |
| 76 | white_list=('.*[.]cc$', '.*[.]h$', tool)) |
| 77 | if not input_api.AffectedSourceFiles(file_filter): |
| 78 | return [] |
| 79 | if subprocess.call([tool, '--check-only']): |
| 80 | return [ |
| 81 | output_api.PresubmitError( |
| 82 | 'Please run ' + tool + ' to fix include guards.') |
| 83 | ] |
| 84 | return [] |
| 85 | |
| 86 | |
Hector Dearman | b7fa544 | 2018-11-08 18:39:32 +0000 | [diff] [blame] | 87 | def CheckBinaryDescriptors(input_api, output_api): |
| 88 | tool = 'tools/gen_binary_descriptors' |
| 89 | file_filter = lambda x: input_api.FilterSourceFile( |
| 90 | x, |
Hector Dearman | 1e26914 | 2018-11-14 13:53:08 +0000 | [diff] [blame] | 91 | white_list=('protos/perfetto/.*[.]proto$', '.*[.]h', tool)) |
Hector Dearman | b7fa544 | 2018-11-08 18:39:32 +0000 | [diff] [blame] | 92 | if not input_api.AffectedSourceFiles(file_filter): |
| 93 | return [] |
| 94 | if subprocess.call([tool, '--check-only']): |
| 95 | return [ |
| 96 | output_api.PresubmitError( |
| 97 | 'Please run ' + tool + ' to update binary descriptors.') |
| 98 | ] |
| 99 | return [] |
| 100 | |
| 101 | |
Primiano Tucci | c501080 | 2018-01-19 17:13:21 +0000 | [diff] [blame] | 102 | def CheckMergedTraceConfigProto(input_api, output_api): |
Hector Dearman | 55ef3e0 | 2018-04-11 17:28:55 +0100 | [diff] [blame] | 103 | tool = 'tools/gen_merged_protos' |
Primiano Tucci | c501080 | 2018-01-19 17:13:21 +0000 | [diff] [blame] | 104 | build_file_filter = lambda x: input_api.FilterSourceFile( |
| 105 | x, |
Hector Dearman | 55ef3e0 | 2018-04-11 17:28:55 +0100 | [diff] [blame] | 106 | white_list=('protos/perfetto/.*[.]proto$', tool)) |
Primiano Tucci | c501080 | 2018-01-19 17:13:21 +0000 | [diff] [blame] | 107 | if not input_api.AffectedSourceFiles(build_file_filter): |
| 108 | return [] |
| 109 | if subprocess.call([tool, '--check-only']): |
| 110 | return [ |
| 111 | output_api.PresubmitError( |
Hector Dearman | 55ef3e0 | 2018-04-11 17:28:55 +0100 | [diff] [blame] | 112 | 'perfetto_config.proto or perfetto_trace.proto is out of ' + |
| 113 | 'date. Please run ' + tool + ' to update it.') |
Primiano Tucci | c501080 | 2018-01-19 17:13:21 +0000 | [diff] [blame] | 114 | ] |
| 115 | return [] |
Florian Mayer | 640b7ae | 2018-05-09 15:28:32 +0100 | [diff] [blame] | 116 | |
| 117 | |
| 118 | # Prevent removing or changing lines in event_whitelist. |
| 119 | def CheckWhitelist(input_api, output_api): |
| 120 | for f in input_api.AffectedFiles(): |
| 121 | if f.LocalPath() != 'tools/ftrace_proto_gen/event_whitelist': |
| 122 | continue |
Hector Dearman | b7fa544 | 2018-11-08 18:39:32 +0000 | [diff] [blame] | 123 | if any((not new_line.startswith('removed')) |
Isabelle Taylor | 8d49fa0 | 2018-10-26 13:23:00 +0100 | [diff] [blame] | 124 | and new_line != old_line for old_line, new_line |
Florian Mayer | 640b7ae | 2018-05-09 15:28:32 +0100 | [diff] [blame] | 125 | in itertools.izip(f.OldContents(), f.NewContents())): |
| 126 | return [ |
| 127 | output_api.PresubmitError( |
| 128 | 'event_whitelist only has two supported changes: ' |
| 129 | 'appending a new line, and replacing a line with removed.' |
| 130 | ) |
| 131 | ] |
| 132 | return [] |