commit 28f82182e26674dd561db8033dd269e1c187944c
author Armando Montanez <amontanez@google.com> Fri Feb 05 17:10:43 2021 -0800
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Feb 06 01:48:28 2021 +0000
tree a500b195518473b69d61648a4a7df82743bffae4
parent 84aee94bc8110c015d91df4f8c82604ceca1cadf

pw_allocator: Fix tests on ARM Clang build

 * Fixes test buffer alignment to meet Block requirements.
 * Renames private Block variables to match Google style.

Bugs: pwbug/315
Change-Id: If2323aca3b90c3b9c0da8a3f6402f7af5715df4e
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/31968
Reviewed-by: Keir Mierle <keir@google.com>
Commit-Queue: Armando Montanez <amontanez@google.com>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 06e411d..7985203 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -271,6 +271,7 @@
   # Targets for all module unit test groups.
   pw_test_group("pw_module_tests") {
     group_deps = [
+      "$dir_pw_allocator:tests",
       "$dir_pw_assert:tests",
       "$dir_pw_base64:tests",
       "$dir_pw_blob_store:tests",
@@ -312,19 +313,6 @@
       "$dir_pw_varint:tests",
     ]
 
-    # TODO(pwbug/315): Fix pw_allocator tests on ARM Clang build.
-    _qemu_toolchains = [
-      "lm3s6965evb_qemu_clang_debug",
-      "lm3s6965evb_qemu_clang_size_optimized",
-      "lm3s6965evb_qemu_clang_speed_optimized",
-    ]
-    _toolchain_is_qemu_clang =
-        _qemu_toolchains + [ get_label_info(current_toolchain, "name") ] -
-        [ get_label_info(current_toolchain, "name") ] != _qemu_toolchains
-    if (!_toolchain_is_qemu_clang) {
-      group_deps += [ "$dir_pw_allocator:tests" ]
-    }
-
     if (defined(pw_toolchain_SCOPE.is_host_toolchain) &&
         pw_toolchain_SCOPE.is_host_toolchain) {
       # TODO(pwbug/196): KVS tests are not compatible with device builds as they