commit 2d737bc0760fefa1ac972f54f013b1444e3060d0
author Alexei Frolov <frolv@google.com> Tue Apr 27 23:03:09 2021 -0700
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon May 17 18:48:01 2021 +0000
tree edf1bff46effed8a7630af831574d641f20bb620
parent 1d2ffdf48b0b09401d5d035dc5ca781d621f98f6

pw_rpc: Add default and move/assign constructors to ClientCall

This updates the BaseClientCall and NanopbClientCall classes to have
working default and move constructors. This allows client calls to be
declared statically, supporting asynchronous RPC calls.

Change-Id: I6bb153c0ae435708456291fe65d76fd0da26e94c
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/42729
Commit-Queue: Alexei Frolov <frolv@google.com>
Reviewed-by: Keir Mierle <keir@google.com>

pw_rpc/base_client_call_test.cc

diff --git a/pw_rpc/base_client_call_test.cc b/pw_rpc/base_client_call_test.cc
index 7f15146..8ddf5e1 100644
--- a/pw_rpc/base_client_call_test.cc
+++ b/pw_rpc/base_client_call_test.cc
@@ -35,6 +35,26 @@
   EXPECT_EQ(context.client().active_calls(), 0u);
 }
 
+TEST(BaseClientCall, Move_UnregistersOriginal) {
+  ClientContextForTest context;
+  EXPECT_EQ(context.client().active_calls(), 0u);
+
+  BaseClientCall moved(&context.channel(),
+                       context.service_id(),
+                       context.method_id(),
+                       [](BaseClientCall&, const Packet&) {});
+  EXPECT_EQ(context.client().active_calls(), 1u);
+
+  BaseClientCall call(std::move(moved));
+  EXPECT_EQ(context.client().active_calls(), 1u);
+
+// Ignore use-after-move.
+#ifndef __clang_analyzer__
+  EXPECT_FALSE(moved.active());
+#endif  // __clang_analyzer__
+  EXPECT_TRUE(call.active());
+}
+
 class FakeClientCall : public BaseClientCall {
  public:
   constexpr FakeClientCall(rpc::Channel* channel,