commit 30c5d38058947833c528856f05a76867ca76301a
author Armando Montanez <amontanez@google.com> Mon Nov 29 12:26:09 2021 -0800
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Nov 29 20:54:04 2021 +0000
tree f82c18a14e2be4e56988bb4c40c74495456b65f3
parent 53f260084d032fbf937e09a06c5fca108bede4a1

pw_string: Remove WriteBytes() return value

WriteBytes()'s return value is unused since the function is private, so
this change removes it.

Change-Id: I48963673ea4fe82d7b67b99ee2d2ef304e66fd97
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/71221
Pigweed-Auto-Submit: Armando Montanez <amontanez@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>

pw_string/string_builder.cc

diff --git a/pw_string/string_builder.cc b/pw_string/string_builder.cc
index 01fe431..50dddc6 100644
--- a/pw_string/string_builder.cc
+++ b/pw_string/string_builder.cc
@@ -100,7 +100,7 @@
   return *this;
 }
 
-StringBuilder& StringBuilder::WriteBytes(std::span<const std::byte> data) {
+void StringBuilder::WriteBytes(std::span<const std::byte> data) {
   if (size() + data.size() * 2 > max_size()) {
     SetErrorStatus(Status::ResourceExhausted());
   } else {
@@ -108,8 +108,6 @@
       *this << val;
     }
   }
-
-  return *this;
 }
 
 void StringBuilder::CopySizeAndStatus(const StringBuilder& other) {