commit 30c5d38058947833c528856f05a76867ca76301a
author Armando Montanez <amontanez@google.com> Mon Nov 29 12:26:09 2021 -0800
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Nov 29 20:54:04 2021 +0000
tree f82c18a14e2be4e56988bb4c40c74495456b65f3
parent 53f260084d032fbf937e09a06c5fca108bede4a1

pw_string: Remove WriteBytes() return value

WriteBytes()'s return value is unused since the function is private, so
this change removes it.

Change-Id: I48963673ea4fe82d7b67b99ee2d2ef304e66fd97
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/71221
Pigweed-Auto-Submit: Armando Montanez <amontanez@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>

pw_string/string_builder_test.cc

diff --git a/pw_string/string_builder_test.cc b/pw_string/string_builder_test.cc
index d6f114c..1e0dc09 100644
--- a/pw_string/string_builder_test.cc
+++ b/pw_string/string_builder_test.cc
@@ -379,7 +379,7 @@
   EXPECT_STREQ("hi!", buffer.data());
 }
 
-TEST(StringBuilder, StreamOutput_ByteSpan) {
+TEST(StringBuilder, StreamOutput_ByteArray) {
   StringBuffer<7> buffer;
   std::array<std::byte, 3> data{
       {std::byte(0xc8), std::byte(0x02), std::byte(0x41)}};
@@ -388,10 +388,22 @@
   EXPECT_STREQ("c80241", buffer.data());
 }
 
+TEST(StringBuilder, StreamOutput_ByteSpan) {
+  StringBuffer<11> buffer;
+  std::array<std::byte, 5> data{{std::byte(0),
+                                 std::byte(0xc8),
+                                 std::byte(0x02),
+                                 std::byte(0x41),
+                                 std::byte(0xe0)}};
+  buffer << std::as_bytes(std::span(data));
+  EXPECT_EQ(buffer.status(), OkStatus());
+  EXPECT_STREQ("00c80241e0", buffer.data());
+}
+
 TEST(StringBuilder, StreamOutput_ByteSpanOutOfSpace) {
   StringBuffer<4> buffer;
   std::array<uint8_t, 3> data{{0xc8, 0x02, 0x41}};
-  buffer << as_bytes(std::span(data));
+  buffer << std::as_bytes(std::span(data));
   EXPECT_EQ(buffer.status(), Status::ResourceExhausted());
   EXPECT_STREQ("", buffer.data());
 }