commit 32988e0ba004ca4ad344b9e6095385c2d9d152e3
author Armando Montanez <amontanez@google.com> Fri May 21 11:56:09 2021 -0700
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jul 27 18:12:50 2021 +0000
tree c76b11c287bb12407588d0e43613ce6bf20e7bdc
parent b44d95e599b68c30b8b342ce5e2587b1dba36ab3

pw_protobuf: Deprecate old encoder

Marks the old pw::protobuf::Encoder as deprecated. For the interim, use
pigweed's new pw::protobuf::StreamingEncoder. The
pw::protobuf::MemoryEncoder will be renamed to replace the original
Encoder.

Bugs: 384
Change-Id: Ifbbf73af7c9b6cf5737c326ef10a4ecf70521adf
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/46621
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Armando Montanez <amontanez@google.com>

pw_snapshot/cpp_compile_test.cc

diff --git a/pw_snapshot/cpp_compile_test.cc b/pw_snapshot/cpp_compile_test.cc
index d188d1c..457a23f 100644
--- a/pw_snapshot/cpp_compile_test.cc
+++ b/pw_snapshot/cpp_compile_test.cc
@@ -21,17 +21,15 @@
 namespace pw::snapshot {
 namespace {
 
-constexpr size_t kMaxProtoSize = 256;
-constexpr size_t kMaxNestedProtoDepth = 4;
-
-std::byte encode_buffer[kMaxProtoSize];
-
 TEST(Status, CompileTest) {
-  pw::protobuf::NestedEncoder<kMaxNestedProtoDepth> proto_encoder(
-      encode_buffer);
-  pw::snapshot::Snapshot::Encoder snapshot_encoder(&proto_encoder);
+  constexpr size_t kMaxProtoSize = 256;
+  std::byte encode_buffer[kMaxProtoSize];
+  std::byte submessage_buffer[kMaxProtoSize];
+
+  stream::MemoryWriter writer(encode_buffer);
+  Snapshot::StreamEncoder snapshot_encoder(writer, submessage_buffer);
   {
-    pw::snapshot::Metadata::Encoder metadata_encoder =
+    Metadata::StreamEncoder metadata_encoder =
         snapshot_encoder.GetMetadataEncoder();
     metadata_encoder.WriteReason(
         std::as_bytes(std::span("It just died, I didn't do anything")));
@@ -39,7 +37,7 @@
     metadata_encoder.WriteProjectName(std::as_bytes(std::span("smart-shoe")));
     metadata_encoder.WriteDeviceName(std::as_bytes(std::span("smart-shoe-p1")));
   }
-  ASSERT_TRUE(proto_encoder.Encode().ok());
+  ASSERT_TRUE(snapshot_encoder.status().ok());
 }
 
 }  // namespace