commit a270be71b6f54d8562ca57de602699fb5a5c64bc
author Wyatt Hepler <hepler@google.com> Wed Apr 21 17:38:06 2021 -0700
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Apr 22 16:03:18 2021 +0000
tree 437e1cf13bf813d622baa5c6c9993215f6ed22ce
parent 46f197ed26aebc35ea5493619064e1fa2a45d8a3

pw_presubmit: Unset some Git environment variables in hooks

Git sets environment variables that are visible when running hooks.
These cause problems when running Git from a hook in a submodule.

Fixed: 364
Change-Id: I3d9c2e715d26247e4eda352efb0a668eb9c0ba6b
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/42160
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Reviewed-by: Rob Mohr <mohrr@google.com>

pw_presubmit/py/pw_presubmit/install_hook.py

diff --git a/pw_presubmit/py/pw_presubmit/install_hook.py b/pw_presubmit/py/pw_presubmit/install_hook.py
index 632bd92..62363f9 100755
--- a/pw_presubmit/py/pw_presubmit/install_hook.py
+++ b/pw_presubmit/py/pw_presubmit/install_hook.py
@@ -60,6 +60,12 @@
         line('#!/bin/sh')
         line(f'# {hook} hook generated by {__file__}')
         line()
+        line('# Unset Git environment variables, which are set when this is ')
+        line('# run as a Git hook. These environment variables cause issues ')
+        line('# when trying to run Git commands on other repos from a ')
+        line('# submodule hook.')
+        line('unset $(git rev-parse --local-env-vars)')
+        line()
         line(command)
 
     hook_path.chmod(0o755)