commit d1ca56c8cd410cdf496d22470fca461ad71dfd34
author Adrien Larbanet <adrienl@google.com> Thu Jun 10 14:20:45 2021 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Aug 16 18:43:40 2021 +0000
tree 07326d20e8641110a17fc8184d00ca93629fda9c
parent 2031ac0f8d8ad656ef3281de3a44b432b7a2a7bd

overall: Adding `IgnoreError()` where Status was discarded

Bug: 387
Change-Id: I720b7a99a1c7a24eb8e2554629529d1e24394cb1
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/49041
Reviewed-by: Keir Mierle <keir@google.com>
Commit-Queue: Keir Mierle <keir@google.com>

pw_rpc/server.cc

diff --git a/pw_rpc/server.cc b/pw_rpc/server.cc
index 26874ed..ef08915 100644
--- a/pw_rpc/server.cc
+++ b/pw_rpc/server.cc
@@ -48,7 +48,8 @@
     // Only send an ERROR response if a valid channel ID was provided.
     if (packet.channel_id() != Channel::kUnassignedChannelId) {
       internal::Channel temp_channel(packet.channel_id(), &interface);
-      temp_channel.Send(Packet::ServerError(packet, Status::DataLoss()));
+      temp_channel.Send(Packet::ServerError(packet, Status::DataLoss()))
+          .IgnoreError();  // TODO(pwbug/387): Handle Status properly
     }
     return false;
   }
@@ -62,7 +63,9 @@
   // Since the responders remove themselves from the server in
   // CloseAndSendResponse(), close responders until no responders remain.
   while (!responders_.empty()) {
-    responders_.front().CloseAndSendResponse(OkStatus());
+    responders_.front()
+        .CloseAndSendResponse(OkStatus())
+        .IgnoreError();  // TODO(pwbug/387): Handle Status properly
   }
 }
 
@@ -84,16 +87,18 @@
     if (channel == nullptr) {
       // If a channel can't be assigned, send a RESOURCE_EXHAUSTED error.
       internal::Channel temp_channel(packet.channel_id(), &interface);
-      temp_channel.Send(
-          Packet::ServerError(packet, Status::ResourceExhausted()));
-      return OkStatus();  // OK since the packet was handled
+      temp_channel
+          .Send(Packet::ServerError(packet, Status::ResourceExhausted()))
+          .IgnoreError();  // TODO(pwbug/387): Handle Status properly
+      return OkStatus();   // OK since the packet was handled
     }
   }
 
   const auto [service, method] = FindMethod(packet);
 
   if (method == nullptr) {
-    channel->Send(Packet::ServerError(packet, Status::NotFound()));
+    channel->Send(Packet::ServerError(packet, Status::NotFound()))
+        .IgnoreError();  // TODO(pwbug/387): Handle Status properly
     return OkStatus();
   }
 
@@ -132,7 +137,8 @@
       HandleClientStreamPacket(packet, *channel, responder);
       break;
     default:
-      channel->Send(Packet::ServerError(packet, Status::Unimplemented()));
+      channel->Send(Packet::ServerError(packet, Status::Unimplemented()))
+          .IgnoreError();  // TODO(pwbug/387): Handle Status properly
       PW_LOG_WARN("Unable to handle packet of type %u",
                   unsigned(packet.type()));
   }
@@ -159,17 +165,20 @@
   if (responder == responders_.end()) {
     PW_LOG_DEBUG(
         "Received client stream packet for method that is not pending");
-    channel.Send(Packet::ServerError(packet, Status::FailedPrecondition()));
+    channel.Send(Packet::ServerError(packet, Status::FailedPrecondition()))
+        .IgnoreError();  // TODO(pwbug/387): Handle Status properly
     return;
   }
 
   if (!responder->has_client_stream()) {
-    channel.Send(Packet::ServerError(packet, Status::InvalidArgument()));
+    channel.Send(Packet::ServerError(packet, Status::InvalidArgument()))
+        .IgnoreError();  // TODO(pwbug/387): Handle Status properly
     return;
   }
 
   if (!responder->client_stream_open()) {
-    channel.Send(Packet::ServerError(packet, Status::FailedPrecondition()));
+    channel.Send(Packet::ServerError(packet, Status::FailedPrecondition()))
+        .IgnoreError();  // TODO(pwbug/387): Handle Status properly
     return;
   }
 
@@ -184,7 +193,8 @@
                                 internal::Channel& channel,
                                 ResponderIterator responder) const {
   if (responder == responders_.end()) {
-    channel.Send(Packet::ServerError(packet, Status::FailedPrecondition()));
+    channel.Send(Packet::ServerError(packet, Status::FailedPrecondition()))
+        .IgnoreError();  // TODO(pwbug/387): Handle Status properly
     PW_LOG_DEBUG("Received CANCEL packet for method that is not pending");
   } else {
     responder->HandleError(Status::Cancelled());