commit d1ca56c8cd410cdf496d22470fca461ad71dfd34
author Adrien Larbanet <adrienl@google.com> Thu Jun 10 14:20:45 2021 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Aug 16 18:43:40 2021 +0000
tree 07326d20e8641110a17fc8184d00ca93629fda9c
parent 2031ac0f8d8ad656ef3281de3a44b432b7a2a7bd

overall: Adding `IgnoreError()` where Status was discarded

Bug: 387
Change-Id: I720b7a99a1c7a24eb8e2554629529d1e24394cb1
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/49041
Reviewed-by: Keir Mierle <keir@google.com>
Commit-Queue: Keir Mierle <keir@google.com>

pw_snapshot/cpp_compile_test.cc

diff --git a/pw_snapshot/cpp_compile_test.cc b/pw_snapshot/cpp_compile_test.cc
index 457a23f..f9bec87 100644
--- a/pw_snapshot/cpp_compile_test.cc
+++ b/pw_snapshot/cpp_compile_test.cc
@@ -31,11 +31,16 @@
   {
     Metadata::StreamEncoder metadata_encoder =
         snapshot_encoder.GetMetadataEncoder();
-    metadata_encoder.WriteReason(
-        std::as_bytes(std::span("It just died, I didn't do anything")));
-    metadata_encoder.WriteFatal(true);
-    metadata_encoder.WriteProjectName(std::as_bytes(std::span("smart-shoe")));
-    metadata_encoder.WriteDeviceName(std::as_bytes(std::span("smart-shoe-p1")));
+    metadata_encoder
+        .WriteReason(
+            std::as_bytes(std::span("It just died, I didn't do anything")))
+        .IgnoreError();  // TODO(pwbug/387): Handle Status properly
+    metadata_encoder.WriteFatal(true)
+        .IgnoreError();  // TODO(pwbug/387): Handle Status properly
+    metadata_encoder.WriteProjectName(std::as_bytes(std::span("smart-shoe")))
+        .IgnoreError();  // TODO(pwbug/387): Handle Status properly
+    metadata_encoder.WriteDeviceName(std::as_bytes(std::span("smart-shoe-p1")))
+        .IgnoreError();  // TODO(pwbug/387): Handle Status properly
   }
   ASSERT_TRUE(snapshot_encoder.status().ok());
 }