Add a bunch of GIL release/acquire points in tp_print implementations and for
PyObject_Print().
Closes issue #1164.
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
index 30b3598..aa61e8c 100644
--- a/Objects/dictobject.c
+++ b/Objects/dictobject.c
@@ -867,11 +867,15 @@
if (status != 0) {
if (status < 0)
return status;
+ Py_BEGIN_ALLOW_THREADS
fprintf(fp, "{...}");
+ Py_END_ALLOW_THREADS
return 0;
}
+ Py_BEGIN_ALLOW_THREADS
fprintf(fp, "{");
+ Py_END_ALLOW_THREADS
any = 0;
for (i = 0; i <= mp->ma_mask; i++) {
dictentry *ep = mp->ma_table + i;
@@ -880,14 +884,19 @@
/* Prevent PyObject_Repr from deleting value during
key format */
Py_INCREF(pvalue);
- if (any++ > 0)
+ if (any++ > 0) {
+ Py_BEGIN_ALLOW_THREADS
fprintf(fp, ", ");
+ Py_END_ALLOW_THREADS
+ }
if (PyObject_Print((PyObject *)ep->me_key, fp, 0)!=0) {
Py_DECREF(pvalue);
Py_ReprLeave((PyObject*)mp);
return -1;
}
+ Py_BEGIN_ALLOW_THREADS
fprintf(fp, ": ");
+ Py_END_ALLOW_THREADS
if (PyObject_Print(pvalue, fp, 0) != 0) {
Py_DECREF(pvalue);
Py_ReprLeave((PyObject*)mp);
@@ -896,7 +905,9 @@
Py_DECREF(pvalue);
}
}
+ Py_BEGIN_ALLOW_THREADS
fprintf(fp, "}");
+ Py_END_ALLOW_THREADS
Py_ReprLeave((PyObject*)mp);
return 0;
}