Apply two changes, systematically:
(1) Use PyErr_NewException("module.class", NULL, NULL) to create the
exception object.
(2) Remove all calls to Py_FatalError(); instead, return or
ignore the errors -- the import code now checks PyErr_Occurred()
after calling a module's init function, so it's no longer a
fatal error for the initialization to fail.
Also did some small cleanups, e.g. removed unnecessary test for
"already initialized" from initfpectl(), and unified
initposix()/initnt().
I haven't checked this very thoroughly, so while the changes are
pretty trivial -- beware of untested code!
diff --git a/Modules/dbmmodule.c b/Modules/dbmmodule.c
index 0b0cb70..ea628f1 100644
--- a/Modules/dbmmodule.c
+++ b/Modules/dbmmodule.c
@@ -317,7 +317,7 @@
m = Py_InitModule("dbm", dbmmodule_methods);
d = PyModule_GetDict(m);
- DbmError = PyString_FromString("dbm.error");
- if ( DbmError == NULL || PyDict_SetItemString(d, "error", DbmError) )
- Py_FatalError("can't define dbm.error");
+ DbmError = PyErr_NewException("dbm.error", NULL, NULL);
+ if (DbmError != NULL)
+ PyDict_SetItemString(d, "error", DbmError);
}