Apply two changes, systematically:
(1) Use PyErr_NewException("module.class", NULL, NULL) to create the
exception object.
(2) Remove all calls to Py_FatalError(); instead, return or
ignore the errors -- the import code now checks PyErr_Occurred()
after calling a module's init function, so it's no longer a
fatal error for the initialization to fail.
Also did some small cleanups, e.g. removed unnecessary test for
"already initialized" from initfpectl(), and unified
initposix()/initnt().
I haven't checked this very thoroughly, so while the changes are
pretty trivial -- beware of untested code!
diff --git a/Modules/rgbimgmodule.c b/Modules/rgbimgmodule.c
index 18d2776..36f6419 100644
--- a/Modules/rgbimgmodule.c
+++ b/Modules/rgbimgmodule.c
@@ -782,9 +782,7 @@
PyObject *m, *d;
m = Py_InitModule("rgbimg", rgbimg_methods);
d = PyModule_GetDict(m);
- ImgfileError = PyString_FromString("rgbimg.error");
- if (ImgfileError)
+ ImgfileError = PyErr_NewException("rgbimg.error", NULL, NULL);
+ if (ImgfileError != NULL)
PyDict_SetItemString(d, "error", ImgfileError);
- if (PyErr_Occurred())
- Py_FatalError("can't initialize rgbimg module");
}