Fixes issue #26083: Workaround a subprocess bug that raised an incorrect
"ValueError: insecure string pickle" exception instead of the actual exception
on some platforms such as Mac OS X when an exception raised in the forked child
process prior to the exec() was large enough that it overflowed the internal
errpipe_read pipe buffer.
diff --git a/Lib/subprocess.py b/Lib/subprocess.py
index 4e7b064..78189f4 100644
--- a/Lib/subprocess.py
+++ b/Lib/subprocess.py
@@ -1313,8 +1313,12 @@
os.close(errpipe_write)
# Wait for exec to fail or succeed; possibly raising exception
- # Exception limited to 1M
data = _eintr_retry_call(os.read, errpipe_read, 1048576)
+ pickle_bits = [data]
+ while data:
+ pickle_bits.append(data)
+ data = _eintr_retry_call(os.read, errpipe_read, 1048576)
+ data = "".join(pickle_bits)
finally:
if p2cread is not None and p2cwrite is not None:
_close_in_parent(p2cread)