commit 10514a70ace6ba5b67d2b34dc4c0738d30f51226
author Peter Astrand <astrand@lysator.liu.se> Sat Jan 13 22:35:35 2007 +0000
committer Peter Astrand <astrand@lysator.liu.se> Sat Jan 13 22:35:35 2007 +0000
tree 6b7d1b75db29707d5d374bb2307ddc0c055868fe
parent 2be9d43c18213be2387f3cdaf9d7bf02fdd37e8d

Fix for bug #1634343: allow specifying empty arguments on Windows

Lib/subprocess.py

diff --git a/Lib/subprocess.py b/Lib/subprocess.py
index ea1e0d1..8b25c2f 100644
--- a/Lib/subprocess.py
+++ b/Lib/subprocess.py
@@ -499,7 +499,7 @@
         if result:
             result.append(' ')
 
-        needquote = (" " in arg) or ("\t" in arg)
+        needquote = (" " in arg) or ("\t" in arg) or arg == ""
         if needquote:
             result.append('"')
 

Lib/test/test_subprocess.py

diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index 64f8d40..c2db6fa 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -430,6 +430,8 @@
                          '"a\\\\b c" d e')
         self.assertEqual(subprocess.list2cmdline(['a\\\\b\\ c', 'd', 'e']),
                          '"a\\\\b\\ c" d e')
+        self.assertEqual(subprocess.list2cmdline(['ab', '']),
+                         'ab ""')
 
 
     def test_poll(self):