commit 1626a479e22db3d44bcd6736d571243433cb6d0e
author Mariatta <Mariatta@users.noreply.github.com> Sat May 27 07:19:55 2017 -0700
committer GitHub <noreply@github.com> Sat May 27 07:19:55 2017 -0700
tree 8cf90a3a5e48139c33497685ca661a17eb7bd6fb
parent 96f502059717a692ca3abd968b26c5ea2918ad3a

[2.7] bpo-29960 _random.Random corrupted on exception in setstate(). … (#1289)

(cherry picked from commit 9616a82e7802241a4b74cf7ae38d43c37bf66e48)

Modules/_randommodule.c

diff --git a/Modules/_randommodule.c b/Modules/_randommodule.c
index 4b9b0eb..852b810 100644
--- a/Modules/_randommodule.c
+++ b/Modules/_randommodule.c
@@ -341,6 +341,7 @@
     int i;
     unsigned long element;
     long index;
+    unsigned long new_state[N];
 
     if (!PyTuple_Check(state)) {
         PyErr_SetString(PyExc_TypeError,
@@ -357,7 +358,7 @@
         element = PyLong_AsUnsignedLong(PyTuple_GET_ITEM(state, i));
         if (element == (unsigned long)-1 && PyErr_Occurred())
             return NULL;
-        self->state[i] = element & 0xffffffffUL; /* Make sure we get sane state */
+        new_state[i] = element & 0xffffffffUL; /* Make sure we get sane state */
     }
 
     index = PyLong_AsLong(PyTuple_GET_ITEM(state, i));
@@ -368,6 +369,8 @@
         return NULL;
     }
     self->index = (int)index;
+    for (i = 0; i < N; i++)
+        self->state[i] = new_state[i];
 
     Py_INCREF(Py_None);
     return Py_None;