Issue #11391: Writing to a mmap object created with
`mmap.PROT_READ|mmap.PROT_EXEC` would segfault instead of raising a
TypeError. Patch by Charles-François Natali.
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
index c8c8cb2..f484a7a 100644
--- a/Modules/mmapmodule.c
+++ b/Modules/mmapmodule.c
@@ -1075,17 +1075,22 @@
prot = PROT_READ | PROT_WRITE;
break;
case ACCESS_DEFAULT:
- /* use the specified or default values of flags and prot */
+ /* map prot to access type */
+ if ((prot & PROT_READ) && (prot & PROT_WRITE)) {
+ /* ACCESS_DEFAULT */
+ }
+ else if (prot & PROT_WRITE) {
+ access = ACCESS_WRITE;
+ }
+ else {
+ access = ACCESS_READ;
+ }
break;
default:
return PyErr_Format(PyExc_ValueError,
"mmap invalid access parameter.");
}
- if (prot == PROT_READ) {
- access = ACCESS_READ;
- }
-
#ifdef HAVE_FSTAT
# ifdef __VMS
/* on OpenVMS we must ensure that all bytes are written to the file */