Issue #24286: Register dict views with the MappingView ABCs.
diff --git a/Lib/test/test_collections.py b/Lib/test/test_collections.py
index cd27227..09b5c54 100644
--- a/Lib/test/test_collections.py
+++ b/Lib/test/test_collections.py
@@ -1286,6 +1286,10 @@
self.assertEqual(list(od.viewvalues()), [None for k in s])
self.assertEqual(list(od.viewitems()), [(k, None) for k in s])
+ # See http://bugs.python.org/issue24286
+ self.assertEqual(od.viewkeys(), dict(od).viewkeys())
+ self.assertEqual(od.viewitems(), dict(od).viewitems())
+
def test_override_update(self):
# Verify that subclasses can override update() without breaking __init__()
class MyOD(OrderedDict):
diff --git a/Lib/test/test_dictviews.py b/Lib/test/test_dictviews.py
index 30cfb93..c5d3917 100644
--- a/Lib/test/test_dictviews.py
+++ b/Lib/test/test_dictviews.py
@@ -1,4 +1,5 @@
import unittest
+import collections
from test import test_support
class DictSetTest(unittest.TestCase):
@@ -164,7 +165,26 @@
d[42] = d.viewvalues()
self.assertRaises(RuntimeError, repr, d)
+ def test_abc_registry(self):
+ d = dict(a=1)
+ self.assertIsInstance(d.viewkeys(), collections.KeysView)
+ self.assertIsInstance(d.viewkeys(), collections.MappingView)
+ self.assertIsInstance(d.viewkeys(), collections.Set)
+ self.assertIsInstance(d.viewkeys(), collections.Sized)
+ self.assertIsInstance(d.viewkeys(), collections.Iterable)
+ self.assertIsInstance(d.viewkeys(), collections.Container)
+
+ self.assertIsInstance(d.viewvalues(), collections.ValuesView)
+ self.assertIsInstance(d.viewvalues(), collections.MappingView)
+ self.assertIsInstance(d.viewvalues(), collections.Sized)
+
+ self.assertIsInstance(d.viewitems(), collections.ItemsView)
+ self.assertIsInstance(d.viewitems(), collections.MappingView)
+ self.assertIsInstance(d.viewitems(), collections.Set)
+ self.assertIsInstance(d.viewitems(), collections.Sized)
+ self.assertIsInstance(d.viewitems(), collections.Iterable)
+ self.assertIsInstance(d.viewitems(), collections.Container)
def test_main():