commit 2240ac1eae2dd8674748239af9c61e5ab4faeb2c
author Richard Oudkerk <shibturn@gmail.com> Fri Jul 06 12:05:32 2012 +0100
committer Richard Oudkerk <shibturn@gmail.com> Fri Jul 06 12:05:32 2012 +0100
tree 9e851d9c9d9df1a377e1fd95ed27a9f29f923313
parent 74de1536810946f82c1e6526fff55646fa119b3d

Issue #15261: Stop os.stat(fd) crashing on Windows when fd not open.

Modules/posixmodule.c

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 1bd5e97..b99a5fe 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -1829,7 +1829,10 @@
     HANDLE h;
     int type;
 
-    h = (HANDLE)_get_osfhandle(file_number);
+    if (!_PyVerify_fd(file_number))
+        h = INVALID_HANDLE_VALUE;
+    else
+        h = (HANDLE)_get_osfhandle(file_number);
 
     /* Protocol violation: we explicitly clear errno, instead of
        setting it to a POSIX error. Callers should use GetLastError. */
@@ -8244,8 +8247,6 @@
     /* on OpenVMS we must ensure that all bytes are written to the file */
     fsync(fd);
 #endif
-    if (!_PyVerify_fd(fd))
-        return posix_error();
     Py_BEGIN_ALLOW_THREADS
     res = FSTAT(fd, &st);
     Py_END_ALLOW_THREADS