commit 26a8abf1f47ba14e9b965e351cef9cd238256f4c
author Neal Norwitz <nnorwitz@gmail.com> Sun Aug 13 18:12:26 2006 +0000
committer Neal Norwitz <nnorwitz@gmail.com> Sun Aug 13 18:12:26 2006 +0000
tree ace6e686d75ea207ec30df08951e5fc2fcb539e6
parent ee7c8f9af80ac2fa76987ca25397624915cbaea4

Handle failures from lookup.

Klocwork 341-342

Modules/expat/xmlparse.c

diff --git a/Modules/expat/xmlparse.c b/Modules/expat/xmlparse.c
index 882470d..e04426d 100644
--- a/Modules/expat/xmlparse.c
+++ b/Modules/expat/xmlparse.c
@@ -2795,6 +2795,8 @@
         unsigned long uriHash = 0;
         ((XML_Char *)s)[-1] = 0;  /* clear flag */
         id = (ATTRIBUTE_ID *)lookup(&dtd->attributeIds, s, 0);
+        if (!id)
+          return XML_ERROR_NO_MEMORY;
         b = id->prefix->binding;
         if (!b)
           return XML_ERROR_UNBOUND_PREFIX;
@@ -5340,6 +5342,8 @@
             return NULL;
           id->prefix = (PREFIX *)lookup(&dtd->prefixes, poolStart(&dtd->pool),
                                         sizeof(PREFIX));
+          if (!id->prefix)
+            return NULL;
           if (id->prefix->name == poolStart(&dtd->pool))
             poolFinish(&dtd->pool);
           else