| commit | 27e4a179f277b568f04d482765ab773068ae6ab6 | [log] [tgz] |
|---|---|---|
| author | Martin v. Löwis <martin@v.loewis.de> | Fri May 23 15:18:28 2008 +0000 |
| committer | Martin v. Löwis <martin@v.loewis.de> | Fri May 23 15:18:28 2008 +0000 |
| tree | d3e1911917a15ff77cbd5a1846064c6a28606d52 | |
| parent | 8c255e4173cfc86ff7015b8f75dccf0d41b24003 [diff] [blame] |
Issue #1390: Raise ValueError in toxml when an invalid comment would otherwise be produced.
diff --git a/Lib/xml/dom/minidom.py b/Lib/xml/dom/minidom.py index ae96033..02e82d9 100644 --- a/Lib/xml/dom/minidom.py +++ b/Lib/xml/dom/minidom.py
@@ -1128,6 +1128,8 @@ self.data = self.nodeValue = data def writexml(self, writer, indent="", addindent="", newl=""): + if "--" in self.data: + raise ValueError("'--' is not allowed in a comment node") writer.write("%s<!--%s-->%s" % (indent, self.data, newl))