commit 312a5dc539b583abcbbf006942a4ceead9b9172b
author Fred Drake <fdrake@acm.org> Fri Feb 02 15:13:24 2001 +0000
committer Fred Drake <fdrake@acm.org> Fri Feb 02 15:13:24 2001 +0000
tree f40b2f79b8cef56306d822062448d73a9b92869e
parent 261b8e26f199b8e548d9cf81fc4a94820a5a83db

WeakDictionary.items():  Do not allow (key,ref) pairs to leak out for
    dead references.

Lib/weakref.py

diff --git a/Lib/weakref.py b/Lib/weakref.py
index f6e07c9..cc7b494 100644
--- a/Lib/weakref.py
+++ b/Lib/weakref.py
@@ -67,12 +67,12 @@
                 return o
 
     def items(self):
-        L = self.data.items()
-        for i in range(len(L)):
+        L = []
+        for key, ref in self.data.items():
             key, ref = L[i]
             o = ref()
             if o is not None:
-                L[i] = key, o
+                L.append((key, o))
         return L
 
     def popitem(self):