commit 3e6d71d3360f2b8dd0232b492d0a63cc6b5419d3
author Vinay Sajip <vinay_sajip@yahoo.co.uk> Mon Jun 25 23:18:45 2012 +0100
committer Vinay Sajip <vinay_sajip@yahoo.co.uk> Mon Jun 25 23:18:45 2012 +0100
tree d8bb5356cc345ec54e71b3e6171625e0aeba13a2
parent 1dd75a64aaf8d69e851b125751deaa446de4eef1

Issue #15179: Closed socket on connection failure. Thanks to Kazutaka Morita for the patch.

Lib/logging/handlers.py

diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
index 22f8c34..d4df5c6 100644
--- a/Lib/logging/handlers.py
+++ b/Lib/logging/handlers.py
@@ -761,7 +761,11 @@
         except socket.error:
             self.socket.close()
             self.socket = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
-            self.socket.connect(address)
+            try:
+                self.socket.connect(address)
+            except socket.error:
+                self.socket.close()
+                raise
 
     def encodePriority(self, facility, priority):
         """