commit 424d75a3f57bfd465dd7c7342f79a8afeaafafcb
author Mark Dickinson <dickinsm@gmail.com> Sun Sep 06 10:20:23 2009 +0000
committer Mark Dickinson <dickinsm@gmail.com> Sun Sep 06 10:20:23 2009 +0000
tree b1b4dba85a25d2d7958c6e56509179ee0b921694
parent 45b9f370fcfa267782693fc4d441a5b80afd661b

Merged revisions 74675 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

................
  r74675 | mark.dickinson | 2009-09-06 11:19:23 +0100 (Sun, 06 Sep 2009) | 10 lines

  Merged revisions 74673 via svnmerge from
  svn+ssh://pythondev@svn.python.org/python/trunk

  ........
    r74673 | mark.dickinson | 2009-09-06 11:03:31 +0100 (Sun, 06 Sep 2009) | 3 lines

    Issue #6846: bytearray.pop was returning ints in the range [-128, 128)
    instead of [0, 256).  Thanks Hagen Fürstenau for the report and fix.
  ........
................

Objects/bytearrayobject.c

diff --git a/Objects/bytearrayobject.c b/Objects/bytearrayobject.c
index f3d5697..f8f9469 100644
--- a/Objects/bytearrayobject.c
+++ b/Objects/bytearrayobject.c
@@ -2705,7 +2705,7 @@
     if (PyByteArray_Resize((PyObject *)self, n - 1) < 0)
         return NULL;
 
-    return PyLong_FromLong(value);
+    return PyLong_FromLong((unsigned char)value);
 }
 
 PyDoc_STRVAR(remove__doc__,