commit 465db3c69ad69df013149eaecffc3ac719b177ca
author Victor Stinner <victor.stinner@gmail.com> Sat Jul 26 14:47:56 2014 +0200
committer Victor Stinner <victor.stinner@gmail.com> Sat Jul 26 14:47:56 2014 +0200
tree 9c52f46ead69bf6c7ec7eebe8e5a86391e26d63a
parent 5a1427c8a376652532ad9e815571ed265964fe95

socketmodule.c: backport INVALID_SOCKET from Python 3.5 to simplify the code

Modules/socketmodule.c

diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index 880f311..130b6b3 100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -94,6 +94,10 @@
 #include "structmember.h"
 #include "timefuncs.h"
 
+#ifndef INVALID_SOCKET /* MS defines this */
+#define INVALID_SOCKET (-1)
+#endif
+
 #undef MAX
 #define MAX(x, y) ((x) < (y) ? (y) : (x))
 
@@ -1705,11 +1709,7 @@
         return NULL;
     memset(&addrbuf, 0, addrlen);
 
-#ifdef MS_WINDOWS
     newfd = INVALID_SOCKET;
-#else
-    newfd = -1;
-#endif
 
     if (!IS_SELECTABLE(s))
         return select_error();
@@ -1727,11 +1727,7 @@
     }
     END_SELECT_LOOP(s)
 
-#ifdef MS_WINDOWS
     if (newfd == INVALID_SOCKET)
-#else
-    if (newfd < 0)
-#endif
         return s->errorhandler();
 
     /* Create the new object with unspecified family,
@@ -3185,12 +3181,7 @@
     fd = socket(family, type, proto);
     Py_END_ALLOW_THREADS
 
-#ifdef MS_WINDOWS
-    if (fd == INVALID_SOCKET)
-#else
-    if (fd < 0)
-#endif
-    {
+    if (fd == INVALID_SOCKET) {
         set_error();
         return -1;
     }