commit 4982d5d04acff706cd43c77e757c0121a14a0c8d
author Antoine Pitrou <solipsis@pitrou.net> Fri Jul 25 17:45:59 2008 +0000
committer Antoine Pitrou <solipsis@pitrou.net> Fri Jul 25 17:45:59 2008 +0000
tree c47d0da9c8a8c48a05494e21071e1b51bfe399fd
parent 5255cba4bc64c1571a167ce2b297f19ff0238899

#2242: utf7 decoding crashes on bogus input on some Windows/MSVC versions

Lib/test/test_unicode.py

diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py
index 24e8e77..f825353 100644
--- a/Lib/test/test_unicode.py
+++ b/Lib/test/test_unicode.py
@@ -532,6 +532,9 @@
 
         self.assertEqual(unicode('+3ADYAA-', 'utf-7', 'replace'), u'\ufffd')
 
+        # Issue #2242: crash on some Windows/MSVC versions
+        self.assertRaises(UnicodeDecodeError, '+\xc1'.decode, 'utf-7')
+
     def test_codecs_utf8(self):
         self.assertEqual(u''.encode('utf-8'), '')
         self.assertEqual(u'\u20ac'.encode('utf-8'), '\xe2\x82\xac')

Objects/unicodeobject.c

diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
index a62e929..16d97c3 100644
--- a/Objects/unicodeobject.c
+++ b/Objects/unicodeobject.c
@@ -1523,7 +1523,7 @@
     while (s < e) {
         Py_UNICODE ch;
         restart:
-        ch = *s;
+        ch = (unsigned char) *s;
 
         if (inShift) {
             if ((ch == '-') || !B64CHAR(ch)) {