commit 53aa1d7c5756eda92bd3276dd38dfa1f0c4bcee2
author Benjamin Peterson <benjamin@python.org> Tue Dec 20 13:29:45 2011 -0600
committer Benjamin Peterson <benjamin@python.org> Tue Dec 20 13:29:45 2011 -0600
tree 1a7881dd41e7aa655dccaeb08338da6a29d4ec1c
parent 0f1e3ac897294213c65b58577501c4f2c169d482

fix possible if unlikely leak

Objects/unicodeobject.c

diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
index d13c547..c4cfe1b 100644
--- a/Objects/unicodeobject.c
+++ b/Objects/unicodeobject.c
@@ -8888,9 +8888,13 @@
         /* create entries for translating chars in x to those in y */
         for (i = 0; i < PyUnicode_GET_SIZE(x); i++) {
             key = PyLong_FromLong(PyUnicode_AS_UNICODE(x)[i]);
-            value = PyLong_FromLong(PyUnicode_AS_UNICODE(y)[i]);
-            if (!key || !value)
+            if (!key)
                 goto err;
+            value = PyLong_FromLong(PyUnicode_AS_UNICODE(y)[i]);
+            if (!value) {
+                Py_DECREF(key);
+                goto err;
+            }
             res = PyDict_SetItem(new, key, value);
             Py_DECREF(key);
             Py_DECREF(value);