Issue #1692335: Move initial args assignment to BaseException.__new__
to help pickling of naive subclasses.
diff --git a/Objects/exceptions.c b/Objects/exceptions.c
index 5c85f10..b7e11f8 100644
--- a/Objects/exceptions.c
+++ b/Objects/exceptions.c
@@ -44,6 +44,12 @@
self->traceback = self->cause = self->context = NULL;
self->suppress_context = 0;
+ if (args) {
+ self->args = args;
+ Py_INCREF(args);
+ return (PyObject *)self;
+ }
+
self->args = PyTuple_New(0);
if (!self->args) {
Py_DECREF(self);
@@ -56,12 +62,15 @@
static int
BaseException_init(PyBaseExceptionObject *self, PyObject *args, PyObject *kwds)
{
+ PyObject *tmp;
+
if (!_PyArg_NoKeywords(Py_TYPE(self)->tp_name, kwds))
return -1;
- Py_XDECREF(self->args);
+ tmp = self->args;
self->args = args;
Py_INCREF(self->args);
+ Py_XDECREF(tmp);
return 0;
}