commit 5951f2300f43d75d344d542e171daed47a0382a6
author Serhiy Storchaka <storchaka@gmail.com> Thu Dec 24 10:35:35 2015 +0200
committer Serhiy Storchaka <storchaka@gmail.com> Thu Dec 24 10:35:35 2015 +0200
tree 2e173dda0c0d4c4bf887e8a6a309430d0d9cd5be
parent 6ed42ea08b3a961944e94f1dd941ffabc7657065

Issue #20440: Massive replacing unsafe attribute setting code with special
macro Py_SETREF.

Modules/cdmodule.c

diff --git a/Modules/cdmodule.c b/Modules/cdmodule.c
index 9ee9b0b..9ef8727 100644
--- a/Modules/cdmodule.c
+++ b/Modules/cdmodule.c
@@ -628,12 +628,10 @@
     CDsetcallback(self->ob_cdparser, (CDDATATYPES) type, CD_callback,
                   (void *) self);
 #endif
-    Py_XDECREF(self->ob_cdcallbacks[type].ob_cdcallback);
     Py_INCREF(func);
-    self->ob_cdcallbacks[type].ob_cdcallback = func;
-    Py_XDECREF(self->ob_cdcallbacks[type].ob_cdcallbackarg);
+    Py_SETREF(self->ob_cdcallbacks[type].ob_cdcallback, func);
     Py_INCREF(funcarg);
-    self->ob_cdcallbacks[type].ob_cdcallbackarg = funcarg;
+    Py_SETREF(self->ob_cdcallbacks[type].ob_cdcallbackarg, funcarg);
 
 /*
     if (type == cd_audio) {