commit 5951f2300f43d75d344d542e171daed47a0382a6
author Serhiy Storchaka <storchaka@gmail.com> Thu Dec 24 10:35:35 2015 +0200
committer Serhiy Storchaka <storchaka@gmail.com> Thu Dec 24 10:35:35 2015 +0200
tree 2e173dda0c0d4c4bf887e8a6a309430d0d9cd5be
parent 6ed42ea08b3a961944e94f1dd941ffabc7657065

Issue #20440: Massive replacing unsafe attribute setting code with special
macro Py_SETREF.

Objects/funcobject.c

diff --git a/Objects/funcobject.c b/Objects/funcobject.c
index 51b6c9d..da54069 100644
--- a/Objects/funcobject.c
+++ b/Objects/funcobject.c
@@ -116,8 +116,7 @@
         PyErr_SetString(PyExc_SystemError, "non-tuple default args");
         return -1;
     }
-    Py_XDECREF(((PyFunctionObject *) op) -> func_defaults);
-    ((PyFunctionObject *) op) -> func_defaults = defaults;
+    Py_SETREF(((PyFunctionObject *)op)->func_defaults, defaults);
     return 0;
 }
 
@@ -149,8 +148,7 @@
                      closure->ob_type->tp_name);
         return -1;
     }
-    Py_XDECREF(((PyFunctionObject *) op) -> func_closure);
-    ((PyFunctionObject *) op) -> func_closure = closure;
+    Py_SETREF(((PyFunctionObject *)op)->func_closure, closure);
     return 0;
 }
 
@@ -430,8 +428,7 @@
 
     if (name != Py_None) {
         Py_INCREF(name);
-        Py_DECREF(newfunc->func_name);
-        newfunc->func_name = name;
+        Py_SETREF(newfunc->func_name, name);
     }
     if (defaults != Py_None) {
         Py_INCREF(defaults);