Merged revisions 59565-59594 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk
........
r59568 | facundo.batista | 2007-12-19 13:53:01 +0100 (Wed, 19 Dec 2007) | 3 lines
Some minor cleanups. Thanks Mark Dickinson.
........
r59573 | raymond.hettinger | 2007-12-19 19:13:31 +0100 (Wed, 19 Dec 2007) | 1 line
Fix issue 1661: Flags argument silently ignored in re functions with compiled regexes.
........
r59574 | guido.van.rossum | 2007-12-19 20:41:06 +0100 (Wed, 19 Dec 2007) | 7 lines
Patch #1583 by Adam Olsen.
This adds signal.set_wakeup_fd(fd) which sets a file descriptor to
which a zero byte will be written whenever a C exception handler runs.
I added a simple C API as well, PySignal_SetWakeupFd(fd).
........
r59575 | raymond.hettinger | 2007-12-19 23:14:34 +0100 (Wed, 19 Dec 2007) | 1 line
Bigger range for non-extended opargs.
........
r59576 | guido.van.rossum | 2007-12-19 23:51:13 +0100 (Wed, 19 Dec 2007) | 5 lines
Patch #1549 by Thomas Herve.
This changes the rules for when __hash__ is inherited slightly,
by allowing it to be inherited when one or more of __lt__, __le__,
__gt__, __ge__ are overridden, as long as __eq__ and __ne__ aren't.
........
r59577 | raymond.hettinger | 2007-12-20 02:25:05 +0100 (Thu, 20 Dec 2007) | 1 line
Add comments
........
r59578 | brett.cannon | 2007-12-20 11:09:52 +0100 (Thu, 20 Dec 2007) | 3 lines
Add tests for the warnings module; specifically formatwarning and showwarning.
Still need tests for warn_explicit and simplefilter.
........
r59582 | guido.van.rossum | 2007-12-20 18:28:10 +0100 (Thu, 20 Dec 2007) | 2 lines
Patch #1672 by Joseph Armbruster. Use tempdir() to get a temporary directory.
........
r59584 | georg.brandl | 2007-12-20 22:03:02 +0100 (Thu, 20 Dec 2007) | 2 lines
Fix refleak introduced in r59576.
........
r59586 | guido.van.rossum | 2007-12-21 00:48:28 +0100 (Fri, 21 Dec 2007) | 4 lines
Improve performance of built-in any()/all() by avoiding PyIter_Next() --
using a trick found in ifilter().
Feel free to backport to 2.5.
........
r59591 | andrew.kuchling | 2007-12-22 18:27:02 +0100 (Sat, 22 Dec 2007) | 1 line
Add item
........
diff --git a/Lib/test/test_richcmp.py b/Lib/test/test_richcmp.py
index efe6923..3f97ece 100644
--- a/Lib/test/test_richcmp.py
+++ b/Lib/test/test_richcmp.py
@@ -85,6 +85,35 @@
raise ValueError("Cannot compare vectors of different length")
return other
+
+class SimpleOrder(object):
+ """
+ A simple class that defines order but not full comparison.
+ """
+
+ def __init__(self, value):
+ self.value = value
+
+ def __lt__(self, other):
+ if not isinstance(other, SimpleOrder):
+ return True
+ return self.value < other.value
+
+ def __gt__(self, other):
+ if not isinstance(other, SimpleOrder):
+ return False
+ return self.value > other.value
+
+
+class DumbEqualityWithoutHash(object):
+ """
+ A class that define __eq__, but no __hash__: it shouldn't be hashable.
+ """
+
+ def __eq__(self, other):
+ return False
+
+
opmap = {
"lt": (lambda a,b: a< b, operator.lt, operator.__lt__),
"le": (lambda a,b: a<=b, operator.le, operator.__le__),
@@ -330,8 +359,39 @@
for op in opmap["lt"]:
self.assertIs(op(x, y), True)
+
+class HashableTest(unittest.TestCase):
+ """
+ Test hashability of classes with rich operators defined.
+ """
+
+ def test_simpleOrderHashable(self):
+ """
+ A class that only defines __gt__ and/or __lt__ should be hashable.
+ """
+ a = SimpleOrder(1)
+ b = SimpleOrder(2)
+ self.assert_(a < b)
+ self.assert_(b > a)
+ self.assert_(a.__hash__ is not None)
+
+ def test_notHashableException(self):
+ """
+ If a class is not hashable, it should raise a TypeError with an
+ understandable message.
+ """
+ a = DumbEqualityWithoutHash()
+ try:
+ hash(a)
+ except TypeError as e:
+ self.assertEquals(str(e),
+ "unhashable type: 'DumbEqualityWithoutHash'")
+ else:
+ raise test_support.TestFailed("Should not be here")
+
+
def test_main():
- test_support.run_unittest(VectorTest, NumberTest, MiscTest, DictTest, ListTest)
+ test_support.run_unittest(VectorTest, NumberTest, MiscTest, DictTest, ListTest, HashableTest)
if __name__ == "__main__":
test_main()