Issue #9604: posix.initgroups() encodes the username using the fileystem
encoding and surrogateescape error handler. Patch written by David Watson.
diff --git a/Misc/NEWS b/Misc/NEWS
index f5cfd38..a322b3d 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -83,6 +83,9 @@
Library
-------
+- Issue #9604: posix.initgroups() encodes the username using the fileystem
+ encoding and surrogateescape error handler. Patch written by David Watson.
+
- Issue #9603: posix.ttyname() and posix.ctermid() decode the terminal name
using the filesystem encoding and surrogateescape error handler. Patch
written by David Watson.
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index df7cb83..7151289 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -4249,13 +4249,19 @@
static PyObject *
posix_initgroups(PyObject *self, PyObject *args)
{
+ PyObject *oname;
char *username;
+ int res;
long gid;
- if (!PyArg_ParseTuple(args, "sl:initgroups", &username, &gid))
+ if (!PyArg_ParseTuple(args, "O&l:initgroups",
+ PyUnicode_FSConverter, &oname, &gid))
return NULL;
+ username = PyBytes_AS_STRING(oname);
- if (initgroups(username, (gid_t) gid) == -1)
+ res = initgroups(username, (gid_t) gid);
+ Py_DECREF(oname);
+ if (res == -1)
return PyErr_SetFromErrno(PyExc_OSError);
Py_INCREF(Py_None);