commit 64aae6695fa0f7677b94230540a298d686c071e3
author Mark Hammond <mhammond@skippinet.com.au> Wed Jan 31 05:38:47 2001 +0000
committer Mark Hammond <mhammond@skippinet.com.au> Wed Jan 31 05:38:47 2001 +0000
tree 6f1ad781d8bc2940471da383df81b5714b3307b2
parent 1ff31f9534aef77c6cccebd1cda1abff14b4ebe6

Fix Bug #125891 - os.popen2,3 and 4 leaked file objects on Windows.

Modules/posixmodule.c

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 99e5864..9f44edc 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -2518,6 +2518,8 @@
 			 CloseHandle(hChildStderrRdDup);
 
 		 f = Py_BuildValue("OO",p1,p2);
+		 Py_XDECREF(p1);
+		 Py_XDECREF(p2);
 		 file_count = 2;
 		 break;
 	 }
@@ -2548,6 +2550,9 @@
 		 PyFile_SetBufSize(p2, 0);
 		 PyFile_SetBufSize(p3, 0);
 		 f = Py_BuildValue("OOO",p1,p2,p3);
+		 Py_XDECREF(p1);
+		 Py_XDECREF(p2);
+		 Py_XDECREF(p3);
 		 file_count = 3;
 		 break;
 	 }