commit 65192c175606b502c57421aa62ea5b328d90d850
author Benjamin Peterson <benjamin@python.org> Sat Jul 18 10:59:13 2015 -0700
committer Benjamin Peterson <benjamin@python.org> Sat Jul 18 10:59:13 2015 -0700
tree 6b8449713c54ef1cf4de5b6dbba18f4823fbcb8e
parent 4734372aa0c7ae481bb6b9de0b5c3f9323c670fd

improve style of the convert macro (#24655)

Patch by Brian Cain.

Modules/_ssl.c

diff --git a/Modules/_ssl.c b/Modules/_ssl.c
index b7537e6..dff5925 100644
--- a/Modules/_ssl.c
+++ b/Modules/_ssl.c
@@ -3426,19 +3426,19 @@
     PyObject *odir_env = NULL;
     PyObject *odir = NULL;
 
-#define convert(info, target) { \
+#define CONVERT(info, target) { \
         const char *tmp = (info); \
         target = NULL; \
         if (!tmp) { Py_INCREF(Py_None); target = Py_None; } \
         else { target = PyBytes_FromString(tmp); } \
         if (!target) goto error; \
-    } while(0)
+    } 
 
-    convert(X509_get_default_cert_file_env(), ofile_env);
-    convert(X509_get_default_cert_file(), ofile);
-    convert(X509_get_default_cert_dir_env(), odir_env);
-    convert(X509_get_default_cert_dir(), odir);
-#undef convert
+    CONVERT(X509_get_default_cert_file_env(), ofile_env);
+    CONVERT(X509_get_default_cert_file(), ofile);
+    CONVERT(X509_get_default_cert_dir_env(), odir_env);
+    CONVERT(X509_get_default_cert_dir(), odir);
+#undef CONVERT
 
     return Py_BuildValue("NNNN", ofile_env, ofile, odir_env, odir);