PyFloat_FromString(): Move s_buffer[] up to the top-level function
scope. Previously, s_buffer[] was defined inside the
PyUnicode_Check() scope, but referred to in the outer scope via
assignment to s. This quiets an Insure portability warning.
diff --git a/Objects/floatobject.c b/Objects/floatobject.c
index 26b39e8..5650b41 100644
--- a/Objects/floatobject.c
+++ b/Objects/floatobject.c
@@ -133,6 +133,7 @@
const char *s, *last, *end;
double x;
char buffer[256]; /* For errors */
+ char s_buffer[256];
int len;
if (PyString_Check(v)) {
@@ -140,8 +141,6 @@
len = PyString_GET_SIZE(v);
}
else if (PyUnicode_Check(v)) {
- char s_buffer[256];
-
if (PyUnicode_GET_SIZE(v) >= sizeof(s_buffer)) {
PyErr_SetString(PyExc_ValueError,
"float() literal too large to convert");