commit 6f430e496339aea3e688165340456b555d5e1035
author Antoine Pitrou <solipsis@pitrou.net> Wed Aug 15 23:18:25 2012 +0200
committer Antoine Pitrou <solipsis@pitrou.net> Wed Aug 15 23:18:25 2012 +0200
tree 197393decf924def07e006f3e35cf21f2fec0f08
parent dd7c55250d67de4d430a0c51dba4f3c0cd8f6ed3

Issue #15604: Update uses of PyObject_IsTrue() to check for and handle errors correctly.
Patch by Serhiy Storchaka.

Modules/_posixsubprocess.c

diff --git a/Modules/_posixsubprocess.c b/Modules/_posixsubprocess.c
index 21ad966..44e1613 100644
--- a/Modules/_posixsubprocess.c
+++ b/Modules/_posixsubprocess.c
@@ -525,6 +525,8 @@
         return NULL;
 
     close_fds = PyObject_IsTrue(py_close_fds);
+    if (close_fds < 0)
+        return NULL;
     if (close_fds && errpipe_write < 3) {  /* precondition */
         PyErr_SetString(PyExc_ValueError, "errpipe_write must be >= 3");
         return NULL;